incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomoe Sugihara" <to...@midokura.com>
Subject Review Request: Another clean up for unnecessary parameter conn Clean up unused parameter conn. Add test for LibvirtVMDef Add support for ethernet type
Date Wed, 01 Aug 2012 15:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6284/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Another clean up for unnecessary parameter conn

Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>

Clean up unused parameter conn.

Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>

Add test for LibvirtVMDef

Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>

Add support for ethernet type

Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
ea12b986b0a771c028354637a657b100fc3cfa27 
  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java e1cfa548948c0ae85a8e49b99e488a192fe506f5

  plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/6284/diff/


Testing
-------


Thanks,

Tomoe Sugihara


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message