incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomoe Sugihara" <to...@midokura.com>
Subject Re: Review Request: Fix the agent path according to 7a0a9231c355fee42c67799abe111edcd79998bb
Date Wed, 01 Aug 2012 12:52:59 GMT


> On July 31, 2012, 9:27 a.m., Prasanna Santhanam wrote:
> > Bug Report: http://bugs.cloudstack.org/browse/CS-15776
> > 
> > Saw quite a few whitespace changes as well. Ran a pychecker on the patch and it
looks fine.
> > 
> >
> 
> Tomoe Sugihara wrote:
>     Actually the bug report was similar but for a different review. I didn't create one
for this review.
>     
>     As for the trailing spaces, I wasn't sure if I should clean that up, but I thought
it's a good practice in general to get rid of them.
>     Let me know if I should leave them.
> 
> Prasanna Santhanam wrote:
>     Absolutely - it is a good practice. Even better if we can move all python code to
PEP8 style. Just mentioned the pychecker test since python is picky about spaces. Wanted to
make sure that we didn't have any space errors. I've pushed the fix. Thanks.
> 
> David Nalley wrote:
>     No please do clean up as you go.

OK, will do. 
In that case, I'd recommend to configure on-save hook to cleanup trailing spaces on your editor
or IDE.


- Tomoe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6227/#review9632
-----------------------------------------------------------


On July 31, 2012, 8:29 a.m., Tomoe Sugihara wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6227/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 8:29 a.m.)
> 
> 
> Review request for cloudstack and edison su.
> 
> 
> Description
> -------
> 
> Fix the agent path according to 7a0a9231c355fee42c67799abe111edcd79998bb
> 
> Signed-off-by: Tomoe Sugihara <tomoe@midokura.com>
> 
> 
> Diffs
> -----
> 
>   python/lib/cloudutils/serviceConfig.py 539e26ae7322934de08576918a376c0487157d97 
> 
> Diff: https://reviews.apache.org/r/6227/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomoe Sugihara
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message