incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prasanna Santhanam <prasanna.santha...@citrix.com>
Subject Re: Dependent Patches
Date Wed, 01 Aug 2012 10:53:25 GMT
On Wed, Aug 01, 2012 at 06:41:11AM -0400, Deepak Garg wrote:
> 
> HI All,
> 
> How can we send dependent patches for review ?
> 
> E.g.  If we have two bugs A and B and a patch is already sent for
> bug A for review. Now I want to continue working on the patch for B
> which depends on the code changes for A.
> 
> So if the patch for B is prepared before A gets into the repo, what
> can be done to make sure, it is applied only after A is applied.
> 
> I see the option of 'Parent Diff'  in the review page. Can that be
> used ? Am I supposed to attach two patches in that case, the old one
> (which is already sent for review) and the new one (which is
> dependent on the old one).

You're right. Attach the parent diff of the patch you sent out first
and assume it has been applied to the HEAD of the tree. ReviewBoard
picks this up.

-- 
Prasanna.,

Mime
View raw message