Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of Alena.Prokharchyk@citrix.com
 designates 66.165.176.89 as permitted sender)
From: Alena Prokharchyk <Alena.Prokharchyk@citrix.com>
To: "cloudstack-dev@incubator.apache.org"
	<cloudstack-dev@incubator.apache.org>
Date: Mon, 30 Jul 2012 13:36:08 -0700
Subject: Re: Please remember to close review board requests
Thread-Topic: Please remember to close review board requests
Thread-Index: Ac1ukvQqM/OHij+lS+6pUFWZIqXCiw==
Message-ID: <CC3C3DF9.C913%alena.prokharchyk@citrix.com>
In-Reply-To: 
 <C66C814C1ABFA8449FF65CB44953A8B4012CB9B1EF91@SJCPMAILBOX01.citrite.net>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.0.120402
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

On 7/30/12 1:28 PM, "Edison Su" <Edison.su@citrix.com> wrote:

>
>
>> -----Original Message-----
>> From: Ewan Mellor [mailto:Ewan.Mellor@eu.citrix.com]
>> Sent: Monday, July 30, 2012 1:01 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: RE: Please remember to close review board requests
>>=20
>> > -----Original Message-----
>> > From: John Kinsella [mailto:jlk@stratosec.co]
>> > Sent: Monday, July 30, 2012 10:26 AM
>> > To: cloudstack-dev@incubator.apache.org
>> > Subject: Please remember to close review board requests
>> >
>> > Guys and gals - if you have a request in ReviewBoard that's been
>> marked
>> > "Ship It!" - it might not be obvious, but you need to go back and
>> close
>> > the request by marking it "Submitted."
>> >
>> > Please remember to do this after momentarily basking in the joy of
>> > having your patch accepted. :)
>> >
>> > That'll save us from having to spam the dev list with requests to
>> close
>> > out tickets, and allow us to see easier what needs to be reviewed.
>>=20
>> Shouldn't the committer do this?  If I understand correctly, the
>> workflow is:
>>=20
>> 1. patch gets approved.
>> 2. committer merges patch manually.
>>=20
>> If number 1 happens, but then someone gets distracted before they do
>> number 2, then we don't want the ticket being closed as submitted.  We
>> should have the committer do it after they push (or even better, have
>> some automated system do it).
>
>I tried, but seems as a committer, you can't change the status to
>"Submitted" for a specific patch.
>
>>=20
>> Ewan.
>
>


+1. I could never submit the patches I've reviewed - there is no such
option provided.=20