Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of Chiradeep.Vittal@citrix.com
 designates 66.165.176.63 as permitted sender)
From: Chiradeep Vittal <Chiradeep.Vittal@citrix.com>
To: CloudStack DeveloperList <cloudstack-dev@incubator.apache.org>, Nitin
 Mehta <Nitin.Mehta@citrix.com>, Deepti Dohare <deepti.dohare@citrix.com>
Date: Thu, 12 Jul 2012 11:26:53 -0700
Subject: Re: Review Request: CS-15430 Create snapshot should fail if
 creating snapshot results in exceeding snapshot resource limit for
 domain-admin or user accounts.
Thread-Topic: Review Request: CS-15430 Create snapshot should fail if
 creating snapshot results in exceeding snapshot resource limit for
 domain-admin or user accounts.
Thread-Index: Ac1gW7yNkbr+nbz6SsaABxRc/mID4A==
Message-ID: <CC2461EA.27B9A%chiradeep.vittal@citrix.com>
In-Reply-To: <20120712060251.729.75834@reviews.apache.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.13.0.110805
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Synchronized isn't going to solve all your cases since management servers
can be clustered.=20

You need to use GenericDaoBase.acquireInLockTable for these kinds of
synchronization.

This kind of generic service (atomic increment up to a limit) should be in
the ResourceLimitManager.
Perhaps updateResourceCountForAccount can be modified to take into account
the resource limit.

--
Chiradeep

On 7/11/12 11:02 PM, "Nitin Mehta" <nitin.mehta@citrix.com> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/5806/#review9100
>-----------------------------------------------------------
>
>Ship it!
>
>
>Ship It!
>
>- Nitin Mehta
>
>
>On July 10, 2012, 1:32 p.m., deepti dohare wrote:
>>=20
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/5806/
>> -----------------------------------------------------------
>>=20
>> (Updated July 10, 2012, 1:32 p.m.)
>>=20
>>=20
>> Review request for cloudstack.
>>=20
>>=20
>> Description
>> -------
>>=20
>> Change:
>> 1. Before creating the snapshot, we synchronized checkResourcelimit to
>>allow the users to create the snapshot and increment the resource count.
>> 2. Depending on the failure of snapshot creation/ backup, we are
>>decrementing the resource count.
>>=20
>>=20
>> This addresses bug CS-15430.
>>=20
>>=20
>> Diffs
>> -----
>>=20
>>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
>>50dcf38=20
>>=20
>> Diff: https://reviews.apache.org/r/5806/diff/
>>=20
>>=20
>> Testing
>> -------
>>=20
>> Steps to verify:
>> 1.Login as admin, set snapshot limit '3' for a user account
>> 2.login as user, create a VM1 with data volume
>> 3.trigger 3 create snapshot command from the above data volume,
>>succeeded
>> 4.create one more snapshot, failed, "maximum limit exceeded for account
>>user"
>>=20
>>=20
>> Thanks,
>>=20
>> deepti dohare
>>=20
>>
>