Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6DC77D462 for ; Tue, 24 Jul 2012 18:31:34 +0000 (UTC) Received: (qmail 77046 invoked by uid 500); 24 Jul 2012 18:31:34 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 77014 invoked by uid 500); 24 Jul 2012 18:31:34 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 77004 invoked by uid 99); 24 Jul 2012 18:31:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2012 18:31:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 790A91C17CC; Tue, 24 Jul 2012 18:31:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2351113218357864701==" MIME-Version: 1.0 Subject: Re: Review Request: CS-15540:Shared Networks IPs in Advanced Zone appear as 'Direct IP' in System-Wide-Capacity Dashboard From: "Brian Federle" To: "Brian Federle" Cc: "cloudstack" , "Pranav Saxena" Date: Tue, 24 Jul 2012 18:31:33 -0000 Message-ID: <20120724183133.4030.71590@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Federle" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/6096/ X-Sender: "Brian Federle" References: <20120723200335.4031.90116@reviews.apache.org> In-Reply-To: <20120723200335.4031.90116@reviews.apache.org> Reply-To: "Brian Federle" --===============2351113218357864701== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6096/#review9400 ----------------------------------------------------------- This looks good. Note that Prananv is now a committer, so will push directl= y to master. - Brian Federle On July 23, 2012, 8:03 p.m., Pranav Saxena wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6096/ > ----------------------------------------------------------- > = > (Updated July 23, 2012, 8:03 p.m.) > = > = > Review request for cloudstack and Brian Federle. > = > = > Description > ------- > = > On the Admin dashboard (running CS 3.0.1) , that we have a listing of "Di= rect IPs" which was running low - it is difficult determine which IP range = this was applied . So changing the name to something more informative such = as "Shared Network IPs" = > = > = > This addresses bug CS-15540. > = > = > Diffs > ----- > = > client/WEB-INF/classes/resources/messages.properties 35fe568 = > = > Diff: https://reviews.apache.org/r/6096/diff/ > = > = > Testing > ------- > = > Verified on my local cloudstack set up. > = > = > Thanks, > = > Pranav Saxena > = > --===============2351113218357864701==--