Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2295589556342095168=="
MIME-Version: 1.0
Subject: Re: Review Request: CS-15430 Create snapshot should fail if creating
 snapshot results in exceeding snapshot resource limit for domain-admin or
 user accounts.
From: "Nitin Mehta" <nitin.mehta@citrix.com>
To: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "deepti dohare" <deepti.dohare@citrix.com>,
 "Nitin Mehta" <nitin.mehta@citrix.com>
Date: Tue, 10 Jul 2012 14:23:00 -0000
Message-ID: <20120710142300.22238.89930@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nitin Mehta" <noreply@reviews.apache.org>
References: <20120710133232.729.59938@reviews.apache.org>
In-Reply-To: <20120710133232.729.59938@reviews.apache.org>
Reply-To: "Nitin Mehta" <nitin.mehta@citrix.com>

--===============2295589556342095168==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5806/#review9018
-----------------------------------------------------------


server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
<https://reviews.apache.org/r/5806/#comment19172>

    Why this new if (!backedUp) block when you already have this block abov=
e ? Please put the decrementing logic in above block


server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java
<https://reviews.apache.org/r/5806/#comment19173>

    Did you inquire how we solve this problem in other places in CS ?  I ca=
nt approve this change since we dont want to reinvent the wheel if this has=
 already been solved. If it hasn't been solved then I would want to raise t=
his in the mailing list and hear out a good way of doing this.


- Nitin Mehta


On July 10, 2012, 1:32 p.m., deepti dohare wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5806/
> -----------------------------------------------------------
> =

> (Updated July 10, 2012, 1:32 p.m.)
> =

> =

> Review request for cloudstack.
> =

> =

> Description
> -------
> =

> Change:
> 1. Before creating the snapshot, we synchronized checkResourcelimit to al=
low the users to create the snapshot and increment the resource count.
> 2. Depending on the failure of snapshot creation/ backup, we are decremen=
ting the resource count.
> =

> =

> This addresses bug CS-15430.
> =

> =

> Diffs
> -----
> =

>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 50dcf38 =

> =

> Diff: https://reviews.apache.org/r/5806/diff/
> =

> =

> Testing
> -------
> =

> Steps to verify:
> 1.Login as admin, set snapshot limit '3' for a user account
> 2.login as user, create a VM1 with data volume
> 3.trigger 3 create snapshot command from the above data volume, succeeded
> 4.create one more snapshot, failed, "maximum limit exceeded for account u=
ser"
> =

> =

> Thanks,
> =

> deepti dohare
> =

>


--===============2295589556342095168==--