incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Nalley <da...@gnsa.us>
Subject Re: signing off patches
Date Fri, 06 Jul 2012 13:51:55 GMT
git commit has a --author argument

http://www.kernel.org/pub/software/scm/git/docs/git-commit.html

--David

On Fri, Jul 6, 2012 at 7:48 AM, Abhinandan Prateek
<Abhinandan.Prateek@citrix.com> wrote:
>>-----Original Message-----
>>From: Prasanna Santhanam [mailto:prasanna.santhanam@citrix.com]
>>Sent: Friday, July 06, 2012 4:39 PM
>>To: cloudstack-dev@incubator.apache.org
>>Subject: Re: signing off patches
>>
>>On Fri, Jul 06, 2012 at 07:01:58AM -0400, Abhinandan Prateek wrote:
>>>
>>> After reviewing patches on *review board* downloaded the patch using
>>> "Download Diff". The downloaded patch removes the author information.
>>> Is it the right way to download patch or is there some problem with
>>> the download functionality ?
>>>
>>> -abhi
>>
>>I see my name against the commit:
>>ce7bc5fb26403c5036643278532d9e04a9fd287a I sent through review-board
>>
>>Does it matter if the patch was signed-off by the author?
>>
>>--
>>Prasanna.,
>
> It will be good if we have both author and committer in the committed patch.
> -abhi

Mime
View raw message