incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olga Smola <olya.sm...@gmail.com>
Subject Re: ReviewBoard
Date Wed, 11 Jul 2012 15:20:53 GMT
David,

thank you. Ok, every ticket should be checked if it really was committed.

Olga

On Wed, Jul 11, 2012 at 6:14 PM, David Nalley <david@gnsa.us> wrote:

> On Wed, Jul 11, 2012 at 11:08 AM, Olga Smola <olya.smola@gmail.com> wrote:
> > So if request gets "Ship it!", it should be submitted (choose the
> reviewed
> > ticket and from the menu "Close"/"Submitted"), am I right?
> >
> > Olga
>
> Correct - though I'd confirm that there is actually a corresponding
> commit that is actually made. There have been a number that have had
> 'ship it' in the review that didn't actually get committed til several
> days later.
>
> --David
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message