incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sheng Yang <>
Subject Re: signing off patches
Date Fri, 06 Jul 2012 19:47:02 GMT
On Fri, Jul 6, 2012 at 6:51 AM, David Nalley <> wrote:
> git commit has a --author argument

Reviewboard removed author information is annoying. Otherwise git-am would do
the trick(and force contributor to respect coding style) well.

Anyway to download original file from Reviewboard? I don't think we're
the only one
got this problem.

BTW, in Linux kernel community(and Xen/KVM), the original author is Author,
and maintainer(committor in our case) would do Signed-off-by: to indicate who
accepted this patch. Probably we can borrow some ideas here.


> --David
> On Fri, Jul 6, 2012 at 7:48 AM, Abhinandan Prateek
> <> wrote:
>>>-----Original Message-----
>>>From: Prasanna Santhanam []
>>>Sent: Friday, July 06, 2012 4:39 PM
>>>Subject: Re: signing off patches
>>>On Fri, Jul 06, 2012 at 07:01:58AM -0400, Abhinandan Prateek wrote:
>>>> After reviewing patches on *review board* downloaded the patch using
>>>> "Download Diff". The downloaded patch removes the author information.
>>>> Is it the right way to download patch or is there some problem with
>>>> the download functionality ?
>>>> -abhi
>>>I see my name against the commit:
>>>ce7bc5fb26403c5036643278532d9e04a9fd287a I sent through review-board
>>>Does it matter if the patch was signed-off by the author?
>> It will be good if we have both author and committer in the committed patch.
>> -abhi

View raw message