incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebgoa <run...@gmail.com>
Subject Re: [6/11] AutoScale changes in Apache master
Date Tue, 31 Jul 2012 16:30:02 GMT
Hi Vijay, are you also developing the corresponding ec2 auto-scale api implementation ?

It would be nice if everytime a new feature is developed the corresponding aws api (if it
exsits) is also implemented at the same time.

-Sebastien

On Jul 27, 2012, at 11:17 AM, Vijay Venkatachalam wrote:

> Hi,
> 
> In the next official CloudStack Citrix release, one of the features 
> is AutoScale. The feature development is still going on and we have 
> created a topic branch in asf. At the current stage 
> there are no unit tests, these will be added very soon.  
> 
> Pranav has helped us create a topic branch out of asf/master and we have 
> called it "autoscale". Any enhancement or bugs addressed
> for this feature will be sent as a patch hence forth.
> 
> So, the feature is ready for viewing in asf/autoscale branch. It would be great to
> see some activity in terms of code review/ suggestions/enhancement on autoscale.
> 
> 
> The spec for AutoScale feature was earlier discussed in the dev mailing list, 
> I am attaching one of the threads for reference.
> 
> http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201207.mbox/%3C7B14C05615DB43488B85E143995BD549DFAC03C689@LONPMAILBOX01.citrite.net%3E
> 
> 
> Here is the related functional spec:
> 
> http://wiki.cloudstack.org/display/DesignDocs/Auto+Scale+Feature
> 
> 
> 
> Thank you,
> -Vijay.
> 
> 
> 
>> -----Original Message-----
>> From: Pranav Saxena
>> Sent: Friday, July 27, 2012 7:34 PM
>> To: cloudstack-dev@incubator.apache.org; David Nalley (david@gnsa.us)
>> Cc: Vijay Venkatachalam; Alena Prokharchyk; Deepak Garg
>> Subject: RE: [6/11] AutoScale changes in Apache master
>> 
>> Hi David,
>> 
>> This commit was based on addition of a new feature called AutoScale on
>> which few guys from  Bangalore have been working on , including me . Since
>> this feature was supposed to be pushed in today , so we had to create a new
>> branch asf/autoscale ( pulled out  of 3.0.x - citrix private branch ) and push
>> the changes there. This was as per Alena's request that I should proceed by
>> pushing the changes for the Autoscale feature (since I am the only committer
>> here in Bangalore)  by creating a new branch on apache and the author(
>> Vijay) would send out an email on the cloudstack dev list , mentioning about
>> the Autoscale feature. We'll be merging some more changes very soon.
>> 
>> @Vijay - could you please elaborate on the Autoscale feature ?
>> 
>> Thanks & Regards,
>> Pranav
>> 
>> -----Original Message-----
>> From: David Nalley [mailto:david@gnsa.us]
>> Sent: Friday, July 27, 2012 7:08 PM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Re: [6/11] AutoScale changes in Apache master
>> 
>> Pranav:
>> 
>> A couple of issues:
>> 
>> The commit contained an author statement, this is generally bad form, and
>> unmaintainable. Moreover, the git log should show who the author is. (and I
>> just saw a commit fixing that, thanks for taking care of
>> it.)
>> 
>> But this also suggests that the author isn't you, and I don't recall having seen
>> this come through as a patch request. We have a processes for getting code
>> into CloudStack and none of them involve a non-transparent back channel.
>> This does a disservice to the original author (people aren't seeing patches
>> from him, which impedes his path to becoming a committer) as well as
>> casting doubts over the provenance of the code. All three of the commits
>> appear to have authors that aren't you, did this code come in as a patch to
>> the mailing list, reviews.a.o, or the bug tracker?
>> 
>> --David
>> 
>>> +/**
>>> + * @author Deepak Garg
>>> + */
>>> +


Mime
View raw message