incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kinsella <...@stratosec.co>
Subject Re: Please remember to close review board requests
Date Mon, 30 Jul 2012 20:29:53 GMT
On Jul 30, 2012, at 1:01 PM, Ewan Mellor wrote:
>> -----Original Message-----
>> From: John Kinsella [mailto:jlk@stratosec.co]
>> Sent: Monday, July 30, 2012 10:26 AM
>> To: cloudstack-dev@incubator.apache.org
>> Subject: Please remember to close review board requests
>> 
>> Guys and gals - if you have a request in ReviewBoard that's been marked
>> "Ship It!" - it might not be obvious, but you need to go back and close
>> the request by marking it "Submitted."
>> 
>> Please remember to do this after momentarily basking in the joy of
>> having your patch accepted. :)
>> 
>> That'll save us from having to spam the dev list with requests to close
>> out tickets, and allow us to see easier what needs to be reviewed.
> 
> Shouldn't the committer do this?  If I understand correctly, the workflow is:
> 
> 1. patch gets approved.
> 2. committer merges patch manually.
> 
> If number 1 happens, but then someone gets distracted before they do number 2, then we
don't want the ticket being closed as submitted.  We should have the committer do it after
they push (or even better, have some automated system do it).

It's the committer's responsibility to review the patch and provide feedback or accept the
patch and commit it, if the patch submitter does not have commit permissions.

The patch submitter has to mark the issue as closed - as a committer I do not have the ability
to close a review request. I've reviewed the ReviewBoard docs[0] and this seems to be purposeful
- I think the intended use case is for authors who have commit access on the source tree.

John

0:http://www.reviewboard.org/docs/manual/1.6/users/getting-started/workflow/



Mime
View raw message