incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Nalley" <da...@gnsa.us>
Subject Re: Review Request: Adding Apache license header to all b*xml files under docs
Date Mon, 30 Jul 2012 01:59:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6193/#review9576
-----------------------------------------------------------


partial review so far. 
Thus far it looks good. One comment though: 

In docs/en-US/asynchronous-commands.xml

Original had this:
	<para>Starting in CloudStack 2.x, the notion of asynchronous commands has been introduced.
Commands are designated as asynchronous when they can potentially take a long period of time
to complete such as creating a snapshot or disk volume.  They differ from synchronous commands
by the following:

Your change has this: 
<para>The notion of asynchronous commands were introduced in CloudStack 2.x. Commands
are designated as asynchronous when they can potentially take a long period of time to complete
such as creating a snapshot or disk volume. They differ from synchronous commands by the following:


Comments on this are: 

CloudStack should be &PRODUCT; - we don't want that 'string' translated. It should always
be in the original language as it's a brand. 

Also notion is the subject, which is singular, the verb however is plural. I think it should
be 'the notion...was introduced in....' Or perhaps changed to 'Async commands were introduced...'.







- David Nalley


On July 30, 2012, 1:49 a.m., Joe Brockmeier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6193/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 1:49 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Adding Apache license headers to all b*xml files, fixing the DTD to remove local C:/
drive reference, adding &product; entity to replace CloudPlatform. Also some misc fixes.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/Author_Group.xml faccf5e 
>   docs/en-US/about-pods.xml 45c4da7 
>   docs/en-US/about-virtual-networks.xml 0273bf4 
>   docs/en-US/about-working-with-vms.xml 11d97c0 
>   docs/en-US/accept-membership-invite.xml cb53f7e 
>   docs/en-US/accessing-vms.xml 47089e0 
>   docs/en-US/accounts-users-domains.xml b896f3f 
>   docs/en-US/accounts.xml 1061ce0 
>   docs/en-US/acquire-new-ip-address.xml b8df5ed 
>   docs/en-US/add-additional-guest-network.xml 76baf44 
>   docs/en-US/add-ingress-egress-rules.xml 805761e 
>   docs/en-US/add-iso.xml 1b6cc41 
>   docs/en-US/add-load-balancer-rule.xml 99e61a7 
>   docs/en-US/add-members-to-projects.xml 94888ab 
>   docs/en-US/add-password-management-to-templates.xml 69e1672 
>   docs/en-US/add-projects-members-from-ui.xml 4ad1206 
>   docs/en-US/add-security-group.xml 2f00b6d 
>   docs/en-US/added-API-commands.xml 7136ad4 
>   docs/en-US/added-cloudPlatform-error-codes.xml 05ac883 
>   docs/en-US/adding-IP-addresses-for-the-public-network.xml 5012651 
>   docs/en-US/admin-alerts.xml ebb68c1 
>   docs/en-US/admin-guide.xml a4fbb42 
>   docs/en-US/advanced-zone-configuration.xml cd8a4da 
>   docs/en-US/advanced-zone-physical-network-configuration.xml 73fadec 
>   docs/en-US/alerts.xml 81f5f7f 
>   docs/en-US/allocators.xml 99c9e57 
>   docs/en-US/api-reference.xml c4ca74b 
>   docs/en-US/appendix-a-time-zones.xml 8cd904e 
>   docs/en-US/asynchronous-commands-example.xml 3bc65b6 
>   docs/en-US/asynchronous-commands.xml 8a6255b 
>   docs/en-US/attach-iso-to-vm.xml 4db9db0 
>   docs/en-US/attaching-volume.xml e818a47 
>   docs/en-US/automatic-snapshot-creation-retention.xml 9bf6b34 
>   docs/en-US/basic-zone-configuration.xml 5c5d176 
>   docs/en-US/basic-zone-physical-network-configuration.xml dac86b3 
>   docs/en-US/best-practices-for-vms.xml 000f676 
>   docs/en-US/best-practices-primary-storage.xml 4b4ef9a 
>   docs/en-US/best-practices-secondary-storage.xml 27b889d 
>   docs/en-US/best-practices-templates.xml 71bc97b 
>   docs/en-US/best-practices-virtual-router.xml 07324e8 
> 
> Diff: https://reviews.apache.org/r/6193/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joe Brockmeier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message