incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "disheng su" <edison...@citrix.com>
Subject Re: Review Request: CS-15609 Volumes can be created as a part of VM creation when un-allocated space is insufficient on primary storage
Date Tue, 24 Jul 2012 22:27:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6028/#review9421
-----------------------------------------------------------



server/src/com/cloud/deploy/FirstFitPlanner.java
<https://reviews.apache.org/r/6028/#comment20158>

    1. The logic should be added into findSuitablePoolsForVolumes, as findSuitablePoolsForVolumes
means given a bunch of volumes and its corresponding requirements, find the proper storage
pool for me. 
    2. The actual code should be put into AbstractStoragePoolAllocator, e.g. adding a new
method, called storagepoolhasenoughspace, the input parameter is a map<volume, storagepool>,
then calculate the storagepool has enough space or not.


- disheng su


On July 18, 2012, 1:29 p.m., mice xia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6028/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 1:29 p.m.)
> 
> 
> Review request for cloudstack, Prachi Damle and Nitin Mehta.
> 
> 
> Description
> -------
> 
> fix CS-15609 Volumes can be created as a part of VM creation when un-allocated space
is insufficient on primary storage
> 
> check the availability of un-allocated primary storage space during planning stage, for
multiple-volume VM creation scenario
> 
> modification in findPotentialDeploymentResources:
> for each <volume, storagePool>, test if ( requestedVolumeSize + storagePool.usedCapacity
> storagePool.totalCapacity * overprovisioningFactor * allocatedStorageThredshold
> 
> 
> This addresses bug CS-15609.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/deploy/FirstFitPlanner.java eb82c75 
> 
> Diff: https://reviews.apache.org/r/6028/diff/
> 
> 
> Testing
> -------
> 
> perform following tests: (overprovisioning.factor=1)
> 1) create vm with 20G root + 20G data on one NFS PS, with allocation state 7.82GB/36.72GB,
VM creation failed as expected
> 2) create vm with 20G root + 5G  data on one NFS PS, with allocation state 7.82GB/36.72GB,
threshold=0.85, VM creation failed as expected
> 3) create vm with 20G root + 5G  data on one NFS PS, with allocation state 7.82GB/36.72GB,
threshold=0.99, VM creation succeed as expected
> 
> 
> Thanks,
> 
> mice xia
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message