incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prachi Damle" <prachi.da...@citrix.com>
Subject Re: Review Request: This table should not have a contraint on device and physical network id. This is dealt with in the code and by using the removed field.
Date Tue, 24 Jul 2012 21:41:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5839/#review9416
-----------------------------------------------------------

Ship it!


Fix is good. The code for addNetworkServiceProvider API makes sure only one provider of a
given name exists on a physical network.

- Prachi Damle


On July 9, 2012, 6:44 p.m., Hugo Trippaers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5839/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 6:44 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> While running some test scripts I noticed that the table 'physical_network_service_providers'
has a unique key on the combination of physical_network_id and provider_name, this is potentially
a problem when we also use the removed field to indicate a device is removed.
> 
> As Alex indicated this is a bug and here is a proposed fix.
> 
> 
> Diffs
> -----
> 
>   setup/db/create-schema.sql c2efb27 
> 
> Diff: https://reviews.apache.org/r/5839/diff/
> 
> 
> Testing
> -------
> 
> Removed the constraint and added a new device, works and a list devices shows only one
device.
> 
> 
> Thanks,
> 
> Hugo Trippaers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message