incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk" <alena.prokharc...@citrix.com>
Subject Re: Review Request: override toString() in ExceptionResponse
Date Mon, 16 Jul 2012 23:19:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5871/#review9199
-----------------------------------------------------------


The patch looks good, but it failed due to license changes
in ApiServer. Can you please exclude this file from your diff as it
doesn't do anything anyway. And attach the new diff.

- Alena Prokharchyk


On July 10, 2012, 2:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5871/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 2:23 a.m.)
> 
> 
> Review request for cloudstack, Sheng Yang and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> Overriding toString() in ExceptionResponse for better logging. Also detected an older
Citrix copyright header in AsyncJobManagerImpl.java, so removed that. The whitespace corrections
were necessary to not run into errors when using git format-patch.
> 
> 
> This addresses bug CS-15508.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/api/response/ExceptionResponse.java 8d1e3de 
>   server/src/com/cloud/async/AsyncJobManagerImpl.java ffb5762 
> 
> Diff: https://reviews.apache.org/r/5871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message