incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Smola" <olya.sm...@gmail.com>
Subject Review Request: CS-15533: In the ''Add instance'' window, ''Review'' tab, there should be selected offerings listed not only edit buttons.
Date Mon, 16 Jul 2012 14:38:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5988/
-----------------------------------------------------------

Review request for cloudstack and Brian Federle.


Description
-------

Hi Brian,

Could you please review my code. I'll commit it after your review, I should spend some time
to understand how to work with git.

Fix for http://bugs.cloudstack.org/browse/CS-15533 - just fix for the first reported issue
(empty field on Review step).

As for the second one: as previously we saw, it not needed to fix it, "because changing the
values of zone and templates will also re-load the data from subsequent steps (since that
data is dependent on the zone/template selected, network offering etc.). If we changed it
like the reporter wanted, then there the zone wizard may have selected something entirely
different without the user knowing. So, the edit action should be kept as it is."

Thanks,
Olga


This addresses bug CS-15533.


Diffs
-----

  ui/index.jsp af05f4a 
  ui/scripts/ui-custom/instanceWizard.js 13719d4 

Diff: https://reviews.apache.org/r/5988/diff/


Testing
-------


Thanks,

Olga Smola


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message