incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Likitha Shetty" <likitha.she...@citrix.com>
Subject Re: Review Request: Implementation of 3 ec2 commands: ec2-create-tags, ec2-delete-tags and ec2-decribe-tags. Component: AWSAPI.
Date Thu, 12 Jul 2012 05:23:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5802/
-----------------------------------------------------------

(Updated July 12, 2012, 5:23 a.m.)


Review request for cloudstack and Prachi Damle.


Changes
-------

Updating the diff to modify the files that have both licence headers to keep just the Apache
licence.


Description
-------

Adding support in AWSAPI for CloudStack API's that implement the tags feature.


Diffs (updated)
-----

  awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 9e10e09 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2DescribeTags.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2DescribeTagsResponse.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 5f45847 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2ResourceTag.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2TagKeyValue.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2TagTypeId.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Tags.java PRE-CREATION 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2TagsFilterSet.java PRE-CREATION 
  awsapi/src/com/cloud/stack/CloudStackApi.java e46ebdd 
  awsapi/src/com/cloud/stack/models/ApiConstants.java e00a9b9 
  awsapi/src/com/cloud/stack/models/CloudStackResourceTag.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5802/diff/


Testing
-------

Verified the output of,
1. ec2-create-tags for all 4 supported ec2 resources(image, instance, volume and snapshot)
with and without tag-value.
2. ec2-delete-tags for all types of created tags.
3. ec2-describe-tags with and without all supported filter.


Thanks,

Likitha Shetty


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message