incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deepti dohare" <>
Subject Re: Review Request: CS-15430 Create snapshot should fail if creating snapshot results in exceeding snapshot resource limit for domain-admin or user accounts.
Date Tue, 10 Jul 2012 13:32:32 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 10, 2012, 1:32 p.m.)

Review request for cloudstack.


Updated the createSnapshot method to decrement the resource count at one place (in the finally
code block) for all errors.


1. Before creating the snapshot, we synchronized checkResourcelimit to allow the users to
create the snapshot and increment the resource count.
2. Depending on the failure of snapshot creation/ backup, we are decrementing the resource

This addresses bug CS-15430.

Diffs (updated)

  server/src/com/cloud/storage/snapshot/ 50dcf38 



Steps to verify:
1.Login as admin, set snapshot limit '3' for a user account
2.login as user, create a VM1 with data volume
3.trigger 3 create snapshot command from the above data volume, succeeded
4.create one more snapshot, failed, "maximum limit exceeded for account user"


deepti dohare

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message