incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deepti dohare" <deepti.doh...@citrix.com>
Subject Re: Review Request: CS-15429: Create Instance should fail if creating instance results in exceeding volume resource limit for domain-admin or user accounts.
Date Mon, 09 Jul 2012 13:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5766/
-----------------------------------------------------------

(Updated July 9, 2012, 1:14 p.m.)


Review request for cloudstack.


Changes
-------

Updating the patch with the fix for handling the scenario when an instance is created from
an iso image. If an instance is created from an iso, disk offering is not null and only one
root disk volume is created. Making a fix to pass the right resource count if an instance
is created from an iso.


Description
-------

When an instance is created with data volume, account limit for this data volume was not checked
against. Adding a check for that


This addresses bug CS-15429.


Diffs (updated)
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java b3fac70 

Diff: https://reviews.apache.org/r/5766/diff/


Testing
-------

Steps: 
1. create domains /ROOT/d1 + domain-admin account d1domain /ROOT/d2 + user account d2user

2. login admin, set all resource limits for d1domain to be 2, set all resource limits for
d2user to be 3 
3. login d1domain, create VM 1 with no data volume: succeeded, create VM 2 with data volume,
Failed. Error message: Maximum number of resources of type 'volume' for account name=d1domain
in domain id=2 has been exceeded.
4. login d2user, create VM 1 and VM2 both with no data volume: succeeded, create VM 3 with
data volume:failed, 
   Error message: "Maximum number of resources of type 'volume' for account name=d2user in
domain id=3 has been exceeded"


Thanks,

deepti dohare


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message