incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Federle" <brian.fede...@citrix.com>
Subject Re: Review Request: CS-15425: Clicking on "About" button - Message refers to CloudStack instead of CloudPlatform(p1)
Date Fri, 06 Jul 2012 18:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5811/#review8926
-----------------------------------------------------------


Unfortunately this is not relevant for the Apache/OSS version, so a review request isn't applicable
here.

- Brian Federle


On July 6, 2012, 6:33 p.m., Pranav Saxena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5811/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 6:33 p.m.)
> 
> 
> Review request for cloudstack and Brian Federle.
> 
> 
> Description
> -------
> 
> 1. Log in as an admin or regular user.
> 2. On the top right corner of the UI, next to the user name, click on the arrow that
is pointed downwards.
> 3. Click on the "About" Button from the dropdown list.
> 
> =================
> Expected Test Results:
> =================
> 
> CloudPlatform name is expected in the message.BUT "cloudstack" is currently displayed.

> 
> so wrote a helper function to render the text and a regular expression would parse the
rendered text and replace 'cloudstack' with 'cloudPlatform' in case it is a proprietary build.
> 
> 
> This addresses bug CS-15425.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui/core.js a1c58a7 
> 
> Diff: https://reviews.apache.org/r/5811/diff/
> 
> 
> Testing
> -------
> 
> Verified on my local cloudstack set up.Attached the screenshot after the helpder function
was added by me to get the desired output.
> 
> 
> Thanks,
> 
> Pranav Saxena
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message