incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request: Fix for CS-15300 Limits on domain admin accounts
Date Sat, 30 Jun 2012 12:43:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5573/#review8772
-----------------------------------------------------------



server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java
<https://reviews.apache.org/r/5573/#comment18543>

    Why is this required ? I dont think this is correct


- Nitin Mehta


On June 29, 2012, 7:04 p.m., deepti dohare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5573/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 7:04 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Domain Admin accounts now respect the limits imposed on the domain just as a regular
account.
> 
> 
> This addresses bug CS-15300.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 797d9f0 
> 
> Diff: https://reviews.apache.org/r/5573/diff/
> 
> 
> Testing
> -------
> 
> verified that we can impose limits on domain admin accounts.
> 
> Steps to verify:
> ============
> 
> Example: sa1 is sub-domain admin account
> url: http://localhost:8080/client/api?command=updateResourceLimit&resourcetype=0&max=1&account=sa1&domainid=4&apikey=3SeISbzeq0V304jxlfGaQgnLvGRcbgQnOzgiEnpsm-gL2qUgYsEw3CQYAlEn2Z9N3AOuZs_uAFywI8s87r5ZDQ&signature=Wc336kdIFT33FWwdJUVwr2h1vH8%3d
> 
> response:
> <updateresourcelimitresponse cloud-stack-version="3.0.3.2012-06-26T06:03:07Z">
> <resourcelimit>
> <account>sa1</account>
> <domainid>179a496a-d157-4851-a4ec-a29e84e7b32f</domainid>
> <domain>SD1</domain>
> <resourcetype>0</resourcetype>
> <max>1</max>
> </resourcelimit>
> </updateresourcelimitresponse>
> 
> 
> Thanks,
> 
> deepti dohare
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message