incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject git commit: Summary: Allow ssh keypairs to be created if developer flag set and user ! cloud
Date Tue, 15 Jan 2013 21:52:38 GMT
Updated Branches:
  refs/heads/master f7b8ad5e8 -> 47251b51a

Summary: Allow ssh keypairs to be created if developer flag set and user ! cloud

Detail: Previously in the code we allowed the configuration to create ssh
keypairs and put them in the configuration table so that systemvms could have
ssh key auth and work properly if the user was 'cloud' or if the developer
configuration item was set to true. It got changed to requiring both the cloud
user and the developer flag (using an || on a negative) somwhere along the way.
This changes it back to && on a negative to allow us to run as non-cloud users
with the dev flag set, and for cloud to deploy properly without the developer

Signed-off-by: Marcus Sorensen <> 1358285190 -0700


Branch: refs/heads/master
Commit: 47251b51a7bad37c66c0fa460723ede6a3e7b0a9
Parents: f7b8ad5
Author: Marcus Sorensen <>
Authored: Tue Jan 15 14:26:30 2013 -0700
Committer: Marcus Sorensen <>
Committed: Tue Jan 15 14:53:28 2013 -0700

 .../com/cloud/server/  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/server/src/com/cloud/server/ b/server/src/com/cloud/server/
index b25c63f..7e5f424 100755
--- a/server/src/com/cloud/server/
+++ b/server/src/com/cloud/server/
@@ -549,7 +549,7 @@ public class ConfigurationServerImpl implements ConfigurationServer {
         String username = System.getProperty("");
         Boolean devel = Boolean.valueOf(_configDao.getValue("developer"));
-        if (!username.equalsIgnoreCase("cloud") || !devel) {
+        if (!username.equalsIgnoreCase("cloud") && !devel) {
             s_logger.warn("Systemvm keypairs could not be set. Management server should be
run as cloud user, or in development mode.");

View raw message