incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bfede...@apache.org
Subject [16/18] git commit: Pass on the destination host in StartCommand
Date Fri, 04 Jan 2013 22:47:38 GMT
Pass on the destination host in StartCommand

I added this in commit bc94948e0604e0e5931759be3c3d3155e84686f6 to be able to bind
the VNC on KVM on the Private IP Address of the Hypervisor.

This got (accidentally) reverted in commit 110903a91a21c04b931a26354a04bd7f534ba050 breaking
this behaviour with KVM.

By passing the destination host again in StartCommand we are able to bind the VNC to the private
IP address of the hypervisor.

This makes sure the VNC is not open for the world and users don't have to firewall these ports,
nor
do they have to change "vnc_listen" in their qemu.conf libvirt settings.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/7240204a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/7240204a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/7240204a

Branch: refs/heads/ui-plugins
Commit: 7240204a507cce8143c248e6aa635da6dad60ed0
Parents: 42d9c3f
Author: Wido den Hollander <wido@widodh.nl>
Authored: Fri Jan 4 14:31:25 2013 +0100
Committer: Wido den Hollander <wido@widodh.nl>
Committed: Fri Jan 4 14:37:23 2013 +0100

----------------------------------------------------------------------
 .../com/cloud/vm/VirtualMachineManagerImpl.java    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/7240204a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
index 9230f4a..4d94fc5 100755
--- a/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/server/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -764,7 +764,7 @@ public class VirtualMachineManagerImpl implements VirtualMachineManager,
Listene
                     VirtualMachineTO vmTO = hvGuru.implement(vmProfile);
 
                     cmds = new Commands(OnError.Stop);
-                    cmds.addCommand(new StartCommand(vmTO));
+                    cmds.addCommand(new StartCommand(vmTO, dest.getHost()));
 
                     vmGuru.finalizeDeployment(cmds, vmProfile, dest, ctx);
 


Mime
View raw message