incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhais...@apache.org
Subject git commit: api: FIXME for api access checker adapter
Date Wed, 12 Dec 2012 22:22:19 GMT
Updated Branches:
  refs/heads/api_refactoring 472f4f91b -> 7dbdf786c


api: FIXME for api access checker adapter

Signed-off-by: Rohit Yadav <bhaisaab@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/7dbdf786
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/7dbdf786
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/7dbdf786

Branch: refs/heads/api_refactoring
Commit: 7dbdf786cc48244943da7dc7884b23763d4eeb31
Parents: 472f4f9
Author: Rohit Yadav <bhaisaab@apache.org>
Authored: Wed Dec 12 14:21:38 2012 -0800
Committer: Rohit Yadav <bhaisaab@apache.org>
Committed: Wed Dec 12 14:21:38 2012 -0800

----------------------------------------------------------------------
 server/src/com/cloud/api/ApiServer.java |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/7dbdf786/server/src/com/cloud/api/ApiServer.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java
index 38bae13..c7cbaa1 100755
--- a/server/src/com/cloud/api/ApiServer.java
+++ b/server/src/com/cloud/api/ApiServer.java
@@ -770,6 +770,8 @@ public class ApiServer implements HttpRequestHandler {
 
     private boolean isCommandAvailable(User user, String commandName) {
         for(APIAccessChecker apichecker : _apiAccessCheckers) {
+            // Break on the first adapter that validates
+            // FIXME: In case of multiple adapters, this may not be the best way of validation.
See CLOUDSTACK-618
             if (apichecker.canAccessAPI(user, commandName))
                 return true;
         }


Mime
View raw message