incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bfede...@apache.org
Subject git commit: CS-16822: multi-edit UI: Fix blank fields on add item
Date Fri, 16 Nov 2012 16:50:25 GMT
Updated Branches:
  refs/heads/master aa3ae45e6 -> fa1696e3e


CS-16822: multi-edit UI: Fix blank fields on add item

When adding an item, show all returned fields if noSelect is
true. This prevents hidden conditional form fields from having their
row data hidden, such as if an ICMP rule is added and the TCP
start/end port form fields are hidden due to space constraints.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/fa1696e3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/fa1696e3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/fa1696e3

Branch: refs/heads/master
Commit: fa1696e3e6c443857eba25b7d6e857e29b0f1d30
Parents: aa3ae45
Author: Brian Federle <brian.federle@citrix.com>
Authored: Fri Nov 16 08:37:59 2012 -0800
Committer: Brian Federle <brian.federle@citrix.com>
Committed: Fri Nov 16 08:50:17 2012 -0800

----------------------------------------------------------------------
 ui/scripts/ui/widgets/multiEdit.js |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/fa1696e3/ui/scripts/ui/widgets/multiEdit.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/multiEdit.js b/ui/scripts/ui/widgets/multiEdit.js
index bccbab0..9694704 100755
--- a/ui/scripts/ui/widgets/multiEdit.js
+++ b/ui/scripts/ui/widgets/multiEdit.js
@@ -104,9 +104,12 @@
 
         if (!itemData) itemData = [{}];
 
-        if ($multi.find('th,td').filter(function() {
-          return $(this).attr('rel') == fieldName;
-        }).is(':hidden')) return true;
+        if (!options.noSelect &&
+            $multi.find('th,td').filter(function() {
+              return $(this).attr('rel') == fieldName;
+            }).is(':hidden')) {
+          return true;
+        }
 
         if (!field.isPassword) {
           if (field.edit) {


Mime
View raw message