incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alena1...@apache.org
Subject [1/6] git commit: CS-16499: removed useless txn.commit statement. Used to call it to ensure that the lock() on nic object will get removed even in case when we don't do the DB update. But our Transaction code does it automatic
Date Fri, 02 Nov 2012 17:34:49 GMT
Updated Branches:
  refs/heads/master 49919bcc6 -> 3948d7d7c


CS-16499: removed useless txn.commit statement. Used to call it to ensure that the lock()
on nic object will get removed even in case when we don't do the DB update. But our Transaction
code does it automatic


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/705130e4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/705130e4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/705130e4

Branch: refs/heads/master
Commit: 705130e42c01cb510f3482112e6a8231f714092b
Parents: 597bc8c
Author: Alena Prokharchyk <alena.prokharchyk@citrix.com>
Authored: Fri Oct 19 16:29:15 2012 -0700
Committer: Alena Prokharchyk <alena.prokharchyk@citrix.com>
Committed: Fri Nov 2 09:59:37 2012 -0700

----------------------------------------------------------------------
 .../src/com/cloud/network/NetworkManagerImpl.java  |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/705130e4/server/src/com/cloud/network/NetworkManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java b/server/src/com/cloud/network/NetworkManagerImpl.java
index 012b00f..ab1ee78 100755
--- a/server/src/com/cloud/network/NetworkManagerImpl.java
+++ b/server/src/com/cloud/network/NetworkManagerImpl.java
@@ -2261,9 +2261,6 @@ public class NetworkManagerImpl implements NetworkManager, NetworkService,
Manag
                 updateNic(nic, network.getId(), -1);
                 txn.commit();
             }
-        } else {
-            //commiting the empty transaction here as we have to release the lock we've held
-            txn.commit();
         }
     }
 


Mime
View raw message