incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject git commit: Check all TODO and FIXME tasks
Date Fri, 12 Oct 2012 10:03:07 GMT
Updated Branches:
  refs/heads/nicira-l3support ab8ba3d61 -> 51f9a9887


Check all TODO and FIXME tasks

Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/51f9a988
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/51f9a988
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/51f9a988

Branch: refs/heads/nicira-l3support
Commit: 51f9a9887197cd2079b9030ffddce0db0474398f
Parents: ab8ba3d
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Authored: Fri Oct 12 12:02:54 2012 +0200
Committer: Hugo Trippaers <htrippaers@schubergphilis.com>
Committed: Fri Oct 12 12:02:54 2012 +0200

----------------------------------------------------------------------
 ...ePortForwardingRulesOnLogicalRouterCommand.java |    1 -
 .../ConfigurePublicIpsOnLogicalRouterCommand.java  |    1 -
 ...figureStaticNatRulesOnLogicalRouterCommand.java |    1 -
 .../cloud/network/element/NiciraNvpElement.java    |    5 +----
 4 files changed, 1 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/51f9a988/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
index 1d57e35..5f0ea38 100644
--- a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
+++ b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePortForwardingRulesOnLogicalRouterCommand.java
@@ -54,7 +54,6 @@ public class ConfigurePortForwardingRulesOnLogicalRouterCommand extends
Command
 	 */
 	@Override
 	public boolean executeInSequence() {
-		// TODO Auto-generated method stub
 		return false;
 	}
 

http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/51f9a988/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
index 8c7c8d7..0da0b4e 100644
--- a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
+++ b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigurePublicIpsOnLogicalRouterCommand.java
@@ -43,7 +43,6 @@ public class ConfigurePublicIpsOnLogicalRouterCommand extends Command {
 
 	@Override
 	public boolean executeInSequence() {
-		// TODO Auto-generated method stub
 		return false;
 	}
 

http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/51f9a988/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
index 4e5d37c..960f609 100644
--- a/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
+++ b/plugins/network-elements/nicira-nvp/src/com/cloud/agent/api/ConfigureStaticNatRulesOnLogicalRouterCommand.java
@@ -57,7 +57,6 @@ public class ConfigureStaticNatRulesOnLogicalRouterCommand extends Command
{
 	 */
 	@Override
 	public boolean executeInSequence() {
-		// TODO Auto-generated method stub
 		return false;
 	}
 

http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/51f9a988/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
----------------------------------------------------------------------
diff --git a/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
b/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
index 71f8454..1c8b8fb 100644
--- a/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
+++ b/plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java
@@ -268,10 +268,7 @@ public class NiciraNvpElement extends AdapterBase implements
 					+ network.getId());
 		}
 		try {
-			// FIXME Check if any services other than connectiviy are required
-			// If that is the case start the logical router with only the
-			// internal interface, leave the external interfaces to the
-			// IpDeployer
+			// Implement SourceNat immediately as we have al the info already
 			if (_networkManager.isProviderSupportServiceInNetwork(
 					network.getId(), Service.SourceNat, Provider.NiciraNvp)) {
 				s_logger.debug("Apparently we are supposed to provide SourceNat on this network");


Mime
View raw message