incubator-cloudstack-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alena1...@apache.org
Subject [1/11] git commit: VPC: CS-15469: createNetworkACL - startPort is not accepted if protocol is ICMP
Date Fri, 06 Jul 2012 18:11:02 GMT
Updated Branches:
  refs/heads/vpc 31f9d718f -> 7044fa695


VPC: CS-15469: createNetworkACL - startPort is not accepted if protocol is ICMP


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/7044fa69
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/7044fa69
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/7044fa69

Branch: refs/heads/vpc
Commit: 7044fa695dd5017ae2fedcce00aa59b8b70ffbe0
Parents: e1fe161
Author: Alena Prokharchyk <alena.prokharchyk@citrix.com>
Authored: Fri Jul 6 10:01:08 2012 -0700
Committer: Alena Prokharchyk <alena.prokharchyk@citrix.com>
Committed: Fri Jul 6 11:11:36 2012 -0700

----------------------------------------------------------------------
 .../cloud/api/commands/CreateNetworkACLCmd.java    |    2 +-
 .../router/VirtualNetworkApplianceManagerImpl.java |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/7044fa69/api/src/com/cloud/api/commands/CreateNetworkACLCmd.java
----------------------------------------------------------------------
diff --git a/api/src/com/cloud/api/commands/CreateNetworkACLCmd.java b/api/src/com/cloud/api/commands/CreateNetworkACLCmd.java
index 25d433b..574de50 100644
--- a/api/src/com/cloud/api/commands/CreateNetworkACLCmd.java
+++ b/api/src/com/cloud/api/commands/CreateNetworkACLCmd.java
@@ -42,7 +42,7 @@ public class CreateNetworkACLCmd extends BaseAsyncCreateCmd implements FirewallR
             "the protocol for the ACL rule. Valid values are TCP/UDP/ICMP.")
     private String protocol;
 
-    @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER, required=true,
description = "the starting port of ACL")
+    @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER, description =
"the starting port of ACL")
     private Integer publicStartPort;
 
     @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER, description = "the
ending port of ACL")

http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/7044fa69/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index c3b9f3c..347d7fb 100755
--- a/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++ b/server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -52,6 +52,7 @@ import com.cloud.agent.api.GetDomRVersionCmd;
 import com.cloud.agent.api.ModifySshKeysCommand;
 import com.cloud.agent.api.NetworkUsageAnswer;
 import com.cloud.agent.api.NetworkUsageCommand;
+import com.cloud.agent.api.RebootAnswer;
 import com.cloud.agent.api.StartupCommand;
 import com.cloud.agent.api.StopAnswer;
 import com.cloud.agent.api.check.CheckSshAnswer;


Mime
View raw message