Hi Malcolm, We'll need to work out a report schedule with the board[1]. I know we have an upcoming board report but not sure the exact date. In the incubator it was the second Wednesday of the month, guess its the same as a TLP? I assume we forward the report directly to the board? http://incubator.apache.org/guides/graduation.html#new-project-hand-over bob Bob Schellink wrote: > We have a couple of outstanding infra tasks for graduation: > > - Create click.apache.org DNS entry > - Migrate mailing lists to @click.apache.org > - Migrate SVN to TLP > - Migrate JIRA to TLP > > Malcolm, will you be able to take this up with infra? > > We also need to submit a board report for next week Wednesday. > > regards > > bob >
This is great news. Its also nice to see IntelliJ having an open source version available as well. kind regards bob WarnerJan Veldhuis wrote: > > Cool! I'll look at Hantsy's plugin as well to make sure I cover all the > features. With 90% of the IDE's covered, Apache Click will reach a > massive audience when all the three plugins are available! > > Happy coding! > > WarnerJan > > > > On 07-Dec-09 17:23, Naoki Takezoe wrote: >> Hi WarnerJan, >> >> Great! >> >> I knew Hantsy's NetBeans plugin similar to ClickIDE, >> However I don't know about IntelliJ Click plugin. >> http://hantsy.blogspot.com/2009/10/click-for-netbeans-plugin-10-is-avai.html >> >> >> I'm looking forward to your IntelliJ plugin. >> And if your plugin has excellent features than ClickIDE, >> I might make them in ClickIDE also. >> >> Regards, >> >> 2009/12/7 WarnerJan Veldhuis<warnerjan.veldhuis@qprcostcontrol.com>: >> >>> Hello dev, >>> >>> I am currently working on an IntelliJ plugin for Apache Click 2.1.0, >>> which >>> whould look and work the same as the Eclipse plugin. I just want to >>> know if >>> any such effort exists, so I am not duplicating stuff. >>> >>> Also, Naoki Takezoe, do you mind if I make the plugin to look like >>> what you >>> did for Eclipse? >>> >>> Cheers, >>> >>> WarnerJan >>> >>> >>> >>> >> >> >> >
Cool! I'll look at Hantsy's plugin as well to make sure I cover all the features. With 90% of the IDE's covered, Apache Click will reach a massive audience when all the three plugins are available! Happy coding! WarnerJan On 07-Dec-09 17:23, Naoki Takezoe wrote: > Hi WarnerJan, > > Great! > > I knew Hantsy's NetBeans plugin similar to ClickIDE, > However I don't know about IntelliJ Click plugin. > http://hantsy.blogspot.com/2009/10/click-for-netbeans-plugin-10-is-avai.html > > I'm looking forward to your IntelliJ plugin. > And if your plugin has excellent features than ClickIDE, > I might make them in ClickIDE also. > > Regards, > > 2009/12/7 WarnerJan Veldhuis<warnerjan.veldhuis@qprcostcontrol.com>: > >> Hello dev, >> >> I am currently working on an IntelliJ plugin for Apache Click 2.1.0, which >> whould look and work the same as the Eclipse plugin. I just want to know if >> any such effort exists, so I am not duplicating stuff. >> >> Also, Naoki Takezoe, do you mind if I make the plugin to look like what you >> did for Eclipse? >> >> Cheers, >> >> WarnerJan >> >> >> >> > > >
Hi WarnerJan, Great! I knew Hantsy's NetBeans plugin similar to ClickIDE, However I don't know about IntelliJ Click plugin. http://hantsy.blogspot.com/2009/10/click-for-netbeans-plugin-10-is-avai.html I'm looking forward to your IntelliJ plugin. And if your plugin has excellent features than ClickIDE, I might make them in ClickIDE also. Regards, 2009/12/7 WarnerJan Veldhuis <warnerjan.veldhuis@qprcostcontrol.com>: > Hello dev, > > I am currently working on an IntelliJ plugin for Apache Click 2.1.0, which > whould look and work the same as the Eclipse plugin. I just want to know if > any such effort exists, so I am not duplicating stuff. > > Also, Naoki Takezoe, do you mind if I make the plugin to look like what you > did for Eclipse? > > Cheers, > > WarnerJan > > > -- Naoki Takezoe
Hello dev, I am currently working on an IntelliJ plugin for Apache Click 2.1.0, which whould look and work the same as the Eclipse plugin. I just want to know if any such effort exists, so I am not duplicating stuff. Also, Naoki Takezoe, do you mind if I make the plugin to look like what you did for Eclipse? Cheers, WarnerJan
I think in terms of the method name this is correct behaviour. If
there are not roles defined, then I dont think it is correct to say
the user belongs to the empty set of roles.
Making this change could impact existing applications in unexpected ways.
You can always write you menu macro to test for the menu.getRoles().isEmpty()
regards Malcolm Edgar
On Sun, Nov 29, 2009 at 1:18 PM, Bob Schellink <sabob1@gmail.com> wrote:
> Hi all,
>
> If a menu doesn't define any roles, isUserInRoles will return false. I
> wonder if this is the correct default. Wouldn't it be better to return true
> if no roles are defined? Otherwise one will have to define an anonymous role
> and set it on these menus.
>
> regards
>
> bob
>
>
> Proposed change:
>
> public boolean isUserInRoles() {
> // PROPOSED CHANGE START
> List roles = getRoles();
> if (roles == null || roles.isEmpty()) {
> return true;
> }
> // END
>
> if (getAccessController() == null) {
> String msg = "Menu accessController has not been defined";
> throw new IllegalStateException(msg);
> }
>
> HttpServletRequest request = getContext().getRequest();
>
> for (int i = 0, size = roles.size(); i < size; i++) {
> String rolename = (String) roles.get(i);
> if (getAccessController().hasAccess(request, rolename)) {
> return true;
> }
> }
>
> return false;
> }
>
>
We have a couple of outstanding infra tasks for graduation: - Create click.apache.org DNS entry - Migrate mailing lists to @click.apache.org - Migrate SVN to TLP - Migrate JIRA to TLP Malcolm, will you be able to take this up with infra? We also need to submit a board report for next week Wednesday. regards bob
Hi all,
If a menu doesn't define any roles, isUserInRoles will return false. I wonder if this is the
correct
default. Wouldn't it be better to return true if no roles are defined? Otherwise one will
have to
define an anonymous role and set it on these menus.
regards
bob
Proposed change:
public boolean isUserInRoles() {
// PROPOSED CHANGE START
List roles = getRoles();
if (roles == null || roles.isEmpty()) {
return true;
}
// END
if (getAccessController() == null) {
String msg = "Menu accessController has not been defined";
throw new IllegalStateException(msg);
}
HttpServletRequest request = getContext().getRequest();
for (int i = 0, size = roles.size(); i < size; i++) {
String rolename = (String) roles.get(i);
if (getAccessController().hasAccess(request, rolename)) {
return true;
}
}
return false;
}
Update to unreleased Velocity 1.6.3 to fix performance issue
------------------------------------------------------------
Key: CLK-597
URL: https://issues.apache.org/jira/browse/CLK-597
Project: Click
Issue Type: Bug
Components: core
Affects Versions: 2.1.0 RC1
Reporter: Bob Schellink
Assignee: Bob Schellink
Fix For: 2.1.0
A recent issue was raised against Velocity 1.6.2 which invokes the variable toString method
when checking if a variable exists or not.
Thus the following snippet would invoke the Table's toString method twice:
#if ($table)
$table
#end
This can have quite a large impact on performance. This issue[1] was recently solved in Velocity
by introducing a runtime property that sets behavior back to the old default.
However Velocity 1.6.2 is not released yet but we can switch to the unreleased 1.6.3 in the
meantime.
[1]:https://issues.apache.org/jira/browse/VELOCITY-731
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Thanks James, I've added IDs to the buttons as you suggested[1]. kind regards bob [1]: http://svn.apache.org/viewvc/incubator/click/trunk/click/extras/src/org/apache/click/extras/control/PickList.htm?r1=788391&r2=883265&diff_format=h james_sg wrote: > Hi Bob, > > When the user clicks on a Add Row button, a javascript function for the form > table will be called to do something like the following: > > 1) clone the last row of the form table > 2) get all select, input, img & button fields from the cloned row, and > rename the attributes according. I also need to reassign the functions for > the control buttons in the picklist. If there are 2 picklists in the row, i > would have 2 buttons with the same name as <,<<,> or >>. Without an id > value, I would not know which picklist the control buttons belongs to. > 3) append the clone row > > Regards, > James
[ https://issues.apache.org/jira/browse/CLK-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink resolved CLK-596.
-------------------------------
Resolution: Fixed
fixed in trunk
> Update commons collection to 3.2.1
> ----------------------------------
>
> Key: CLK-596
> URL: https://issues.apache.org/jira/browse/CLK-596
> Project: Click
> Issue Type: Task
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Bob Schellink
> Priority: Minor
> Fix For: 2.1.0
>
>
> Update commons collection to 3.2.1. Velocity pom has dependency on this version of CC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink resolved CLK-590.
-------------------------------
Resolution: Fixed
> Scriptaculous contains alert
> ----------------------------
>
> Key: CLK-590
> URL: https://issues.apache.org/jira/browse/CLK-590
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: WarnerJan Veldhuis
> Assignee: Bob Schellink
> Priority: Trivial
> Fix For: 2.1.0
>
>
> The scriptaculous.js script contains an alert on line 51. I assume this is old-school
debugging and should be commented by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Hi Bob, When the user clicks on a Add Row button, a javascript function for the form table will be called to do something like the following: 1) clone the last row of the form table 2) get all select, input, img & button fields from the cloned row, and rename the attributes according. I also need to reassign the functions for the control buttons in the picklist. If there are 2 picklists in the row, i would have 2 buttons with the same name as <,<<,> or >>. Without an id value, I would not know which picklist the control buttons belongs to. 3) append the clone row Regards, James -- View this message in context: http://n2.nabble.com/picklist-tp4045362p4045631.html Sent from the click-development mailing list archive at Nabble.com.
Hi James, Sure, I don't see why not. But from your example I'm not sure why you need it though? The buttons are only used to copy values between the Selects, its not used server side. And since the buttons do not have an ID, you can have multiple buttons per row, they won't clash. I'm probably not seeing the issue just yet. :) kind regards bob james_sg wrote: > Hi, > > I have extended the formtable to allow adding/removal of rows using > javascript. The javascript function will change the id and name of the > fields in each row when necessary. However, the control buttons in a > picklist field doesn't have id values. So I cannot include more than one > picklist in each row. > > Hence, I would like to propose adding an id value to each of the control > button in the picklist control. > > Regards, > James
Hi, I have extended the formtable to allow adding/removal of rows using javascript. The javascript function will change the id and name of the fields in each row when necessary. However, the control buttons in a picklist field doesn't have id values. So I cannot include more than one picklist in each row. Hence, I would like to propose adding an id value to each of the control button in the picklist control. Regards, James -- View this message in context: http://n2.nabble.com/picklist-tp4045362p4045362.html Sent from the click-development mailing list archive at Nabble.com.
Great news all. regards Malcolm Edgar On Sat, Nov 21, 2009 at 8:54 PM, Hantsy Bai <hantsy@gmail.com> wrote: > On 11/21/2009 04:50 PM, Bob Schellink wrote: >> Apache Click has graduated! >> >> Earlier this week the Apache board has established Click as a new >> top-level project. >> >> We will be migrating the website and mailing lists to their new >> locations in the coming days. Subscribers to the incubator mail lists >> will automatically be migrated to the new lists, there is no need to >> resubscribe. >> >> kind regards >> >> bob >> > Congratulations! > > > Best regards > > -- > Hantsy Bai > Guangzhou, China > http://hantsy.blogspot.com > >
Apache Click has graduated! Earlier this week the Apache board has established Click as a new top-level project. We will be migrating the website and mailing lists to their new locations in the coming days. Subscribers to the incubator mail lists will automatically be migrated to the new lists, there is no need to resubscribe. kind regards bob
This is fantastic news. Congratulations to the newly elected PMC members and Malcolm Edgar as our PMC Chair. Also thanks to our mentors, Henning, Will, Andrus and Ted who guided us through the process. Exciting times ahead. kind regards bob Andrus Adamchik wrote: >> B. Establish the Apache Click Project (CMalcolm Edgar, VP) > > Congrats to the Click community - you are an official Apache project > now! :-) > > Andrus >
Great news guys, thanks for your support, and special thanks to Bob for all his hard work over the last year. regards Malcolm Edgar On Fri, Nov 20, 2009 at 1:04 AM, Will Glass-Husain <wglasshusain@gmail.com> wrote: > +1 !! > > On Thu, Nov 19, 2009 at 5:32 AM, Andrus Adamchik <andrus@objectstyle.org> wrote: >>> B. Establish the Apache Click Project (CMalcolm Edgar, VP) >> >> Congrats to the Click community - you are an official Apache project now! >> :-) >> >> Andrus >> >
+1 !! On Thu, Nov 19, 2009 at 5:32 AM, Andrus Adamchik <andrus@objectstyle.org> wrote: >> B. Establish the Apache Click Project (CMalcolm Edgar, VP) > > Congrats to the Click community - you are an official Apache project now! > :-) > > Andrus >
> B. Establish the Apache Click Project (CMalcolm Edgar, VP) Congrats to the Click community - you are an official Apache project now! :-) Andrus
Update commons collection to 3.2.1
----------------------------------
Key: CLK-596
URL: https://issues.apache.org/jira/browse/CLK-596
Project: Click
Issue Type: Task
Components: core
Affects Versions: 2.1.0 RC1
Reporter: Bob Schellink
Assignee: Bob Schellink
Priority: Minor
Fix For: 2.1.0
Update commons collection to 3.2.1. Velocity pom has dependency on this version of CC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776952#action_12776952
]
Bob Schellink commented on CLK-595:
-----------------------------------
No need, I've already updated the status.
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
> Fix For: 2.2.0
>
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776953#action_12776953
]
Stefax commented on CLK-595:
----------------------------
Excuse me, I only see now that you have still changed the type to new feature... :)
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
> Fix For: 2.2.0
>
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776948#action_12776948
]
Stefax commented on CLK-595:
----------------------------
Perfect! Have I to resubmit this issue as a new Feature request?
Thanks for your help!
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
> Fix For: 2.2.0
>
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink reopened CLK-595:
-------------------------------
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
> Fix For: 2.2.0
>
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink updated CLK-595:
------------------------------
Fix Version/s: 2.2.0
Issue Type: New Feature (was: Bug)
Ok, instead of filing this as a bug, lets make it a new feature: add setLabelStyle / setLabelStyleClass
methods on Field.
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
> Fix For: 2.2.0
>
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776936#action_12776936
]
Stefax commented on CLK-595:
----------------------------
Styling margin is something usual and would be nice that the label associated to a field inherit
that settings.
I think that would be useful if the field itself can set the style of its label with a method
like setLabelStyle as the one of the form.
Thinking that all the label in the form must have the same style (form.setLabelStyle()) is
a questionable choice, not convenient for web programming.
I like click framework and I find it very easy to use, so I hope that we can find a solution
convenient for the users and the developers.
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: Bug
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink closed CLK-595.
-----------------------------
Resolution: Won't Fix
This is not a bug. The Label is set by the Form and does not apply the Field styles to the
label.
If you need fine grain control you can style the field and label using CSS selectors or if
that doesn't work, use manual layout or a custom Form.
> Can't apply to TextField label the same style as the one assigned to the Control
> --------------------------------------------------------------------------------
>
> Key: CLK-595
> URL: https://issues.apache.org/jira/browse/CLK-595
> Project: Click
> Issue Type: Bug
> Components: core
> Affects Versions: 2.1.0 RC1
> Environment: tomcat on linux
> Reporter: Stefax
>
> I need to set the same margin-bottom to the TextFiled and its label, but when I call
the method setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
> TextField cld = new TextField("cld", "My Text Field: ");
> cld.setSize(20);
> cld.setRequired(false);
> cld.setStyle("margin-bottom", "20px");
> form.add(cld);
> the resultant html code (generated putting $form in the html) is:
> <td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
> <td align="left"><input type="text" name="cld" id="form_cld" value="" size="20"
style="margin-bottom:20px;"/></td>
> As you can see the style is applied to the intput text, but not to its label.
> This generate a very ugly page, where all the label are rendered not near the fields
they refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink resolved CLK-594.
-------------------------------
Resolution: Duplicate
Thanks Victor, this has been fixed as CLK-593.
> click-nodeps has incorrect dependencies in pom
> ----------------------------------------------
>
> Key: CLK-594
> URL: https://issues.apache.org/jira/browse/CLK-594
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Environment: Apache Maven 2.2.1 (rdebian-1)
> Java version: 1.6.0_15
> Java home: /usr/lib/jvm/java-6-sun-1.6.0.15/jre
> Default locale: en_AU, platform encoding: UTF-8
> OS name: "linux" version: "2.6.31-14-generic-pae" arch: "i386" Family: "unix"
> Reporter: Victor Leung
> Priority: Minor
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> When click-extras is added to the project pom, Maven reports the following error:
> Downloading: http://repo1.maven.org/maven2/velocity/velocity/1.6.2/velocity-1.6.2.pom
> [INFO] Unable to find resource 'velocity:velocity:pom:1.6.2' in repository central (http://repo1.maven.org/maven2)
> Downloading: http://repo1.maven.org/maven2/velocity/velocity/1.6.2/velocity-1.6.2.jar
> [INFO] Unable to find resource 'velocity:velocity:jar:1.6.2' in repository central (http://repo1.maven.org/maven2)
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Failed to resolve artifact.
> In click-nodeps-2.1.0-RC1-incubating.pom, the velocity dependency is incorrectly listed
as:
> <dependency>
> <groupId>velocity</groupId>
> <artifactId>velocity</artifactId>
> <version>1.6.2</version>
> </dependency>
> Changing the groupId to "org.apache.velocity" resolves the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Can't apply to TextField label the same style as the one assigned to the Control
--------------------------------------------------------------------------------
Key: CLK-595
URL: https://issues.apache.org/jira/browse/CLK-595
Project: Click
Issue Type: Bug
Components: core
Affects Versions: 2.1.0 RC1
Environment: tomcat on linux
Reporter: Stefax
I need to set the same margin-bottom to the TextFiled and its label, but when I call the method
setStyle("margin-bottom", "20px") of the TextField, it does not set the same margin/style
to its label; for the java code:
TextField cld = new TextField("cld", "My Text Field: ");
cld.setSize(20);
cld.setRequired(false);
cld.setStyle("margin-bottom", "20px");
form.add(cld);
the resultant html code (generated putting $form in the html) is:
<td class="fields" align="left"><label for="form_cld">My Text Field: </label> </td>
<td align="left"><input type="text" name="cld" id="form_cld" value="" size="20" style="margin-bottom:20px;"/></td>
As you can see the style is applied to the intput text, but not to its label.
This generate a very ugly page, where all the label are rendered not near the fields they
refer to.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
click-nodeps has incorrect dependencies in pom
----------------------------------------------
Key: CLK-594
URL: https://issues.apache.org/jira/browse/CLK-594
Project: Click
Issue Type: Bug
Components: extras
Affects Versions: 2.1.0 RC1
Environment: Apache Maven 2.2.1 (rdebian-1)
Java version: 1.6.0_15
Java home: /usr/lib/jvm/java-6-sun-1.6.0.15/jre
Default locale: en_AU, platform encoding: UTF-8
OS name: "linux" version: "2.6.31-14-generic-pae" arch: "i386" Family: "unix"
Reporter: Victor Leung
Priority: Minor
When click-extras is added to the project pom, Maven reports the following error:
Downloading: http://repo1.maven.org/maven2/velocity/velocity/1.6.2/velocity-1.6.2.pom
[INFO] Unable to find resource 'velocity:velocity:pom:1.6.2' in repository central (http://repo1.maven.org/maven2)
Downloading: http://repo1.maven.org/maven2/velocity/velocity/1.6.2/velocity-1.6.2.jar
[INFO] Unable to find resource 'velocity:velocity:jar:1.6.2' in repository central (http://repo1.maven.org/maven2)
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
In click-nodeps-2.1.0-RC1-incubating.pom, the velocity dependency is incorrectly listed as:
<dependency>
<groupId>velocity</groupId>
<artifactId>velocity</artifactId>
<version>1.6.2</version>
</dependency>
Changing the groupId to "org.apache.velocity" resolves the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink closed CLK-593.
-----------------------------
Resolution: Fixed
Thanks Hantsy, this has already been fixed in trunk.
> The velocity dependency definition in click-nodeps pom is incorretly.
> ----------------------------------------------------------------------
>
> Key: CLK-593
> URL: https://issues.apache.org/jira/browse/CLK-593
> Project: Click
> Issue Type: Bug
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: hantsy bai
>
> The velocity dependency definition in click-nodeps pom is incorretly.
> After 1.6, the groupId may be is org.apache.velocity , not velocity.
> So the correct definition maybe like the following:
> <dependency>
> <groupId>org.apache.velocity</groupId>
> <artifactId>velocity</artifactId>
> <version>1.6.2</version>
> </dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
The velocity dependency definition in click-nodeps pom is incorretly.
----------------------------------------------------------------------
Key: CLK-593
URL: https://issues.apache.org/jira/browse/CLK-593
Project: Click
Issue Type: Bug
Components: core
Affects Versions: 2.1.0 RC1
Reporter: hantsy bai
The velocity dependency definition in click-nodeps pom is incorretly.
After 1.6, the groupId may be is org.apache.velocity , not velocity.
So the correct definition maybe like the following:
<dependency>
<groupId>org.apache.velocity</groupId>
<artifactId>velocity</artifactId>
<version>1.6.2</version>
</dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774278#action_12774278
]
Bob Schellink commented on CLK-564:
-----------------------------------
Hi Malcolm,
I've checked in a change to the ClickResourceService to serve resources lazily. This has some
advantages over eager loading:
- resources won't be loaded if they are not requested. This resolves the issue with eager
loading where all resources from jars are loaded, even if some of those resources aren't valid
static resources, for example Velocity templates with extensions other than .htm.
- removed all duplicate code shared with XmlConfigService
- with lazy loading it was easy to add the ability to only cache resources in production modes
The only feature still outstanding is how to handle the case where Velocity attempts to render
a template contained under META-INF/resources. Currently the VelocityTemplateService caters
for two built in templates, but won't handle custom templates. I suppose we can cross that
bridge when we get there.
> Add ResourceService for serving static resources
> ------------------------------------------------
>
> Key: CLK-564
> URL: https://issues.apache.org/jira/browse/CLK-564
> Project: Click
> Issue Type: New Feature
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Malcolm Edgar
> Assignee: Malcolm Edgar
> Fix For: 2.1.0
>
> Attachments: report_1.html, report_2.html, report_3.html
>
>
> The Click static resource deployment strategy of writing *.htm, *.css and image files
to the web application /click/ directory does not work on all application servers. In particular
WebLogic and WebSphere have security restrictions which prevent this from occuring. In these
scenarios users are have to deploy these applications to the WAR file at build time. Google
GAE also does not support this deployment mode.
> A solution to this problem is to use the ClickServlet to serve these resources. By adding
an additional web.xml mapping:
> <servlet-mapping>
> <servlet-name>ClickServlet</servlet-name>
> <url-pattern>/click/*</url-pattern>
> </servlet-mapping>
> The ClickServlet could use a ResourceService interface obtained from the ConfigService
which returns the resource data. A default ClickResourceService would be provided which loads
all the resources at application initialization time. This service would scan all the JAR
files for resources in META-INF/web as is currently done in XmlConfigService and would cache
them in memory. The service would also scan all the resources under the WAR /click/ directory.
These resources would override any defined in the application JAR files.
> This could be a good feature for 2.1.0, we should possibly delay the 2.1.0 RC release
to include this feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink resolved CLK-589.
-------------------------------
Resolution: Fixed
I've checked in a fix based on the Stripes solution[1] mentioned above. Containers tested
include: JBoss 4, 5, 5.1, Tomcat 6, Jetty 6, WAS 7, WebLogic 10, Glassfish 2.
[1]: https://stripes.svn.sourceforge.net/svnroot/stripes/branches/1.5.x/stripes/src/net/sourceforge/stripes/util/ResolverUtil.java
> Resources not deployed on JBoss5 and up
> ---------------------------------------
>
> Key: CLK-589
> URL: https://issues.apache.org/jira/browse/CLK-589
> Project: Click
> Issue Type: Bug
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Bob Schellink
> Priority: Blocker
> Fix For: 2.1.0
>
>
> Deploying the click-examples failed on JBoss5.1 because of their new Virtual File System
implementation. We might have similar issues on other containers.
> Other frameworks are struggling with the same issue:
> Spring: http://jira.springframework.org/browse/SPR-5120
> Struts2: https://issues.apache.org/struts/browse/WW-3181
> Stripes: http://www.stripesframework.org/jira/browse/STS-655
> The good folks at Stripes seem to have a solution (holding thumbs) which we could adapt
for deploying resources.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773254#action_12773254
]
Malcolm Edgar commented on CLK-591:
-----------------------------------
Agree with this issue and approach. The menu in addition to the label property has a title
property, and an imageSrc property which could also benefit from localization. If we use
the convention used with other controls we can support internationalization as well
menu_logoff.label=Log Off
menu-logoff.title=Logout of the application
menu-logoff.imageSrc=/assets/images/logoff.gif
To do this we would need to introduce the name into the Menu control to follow this convention.
> I18N for Menu control
> ---------------------
>
> Key: CLK-591
> URL: https://issues.apache.org/jira/browse/CLK-591
> Project: Click
> Issue Type: Sub-task
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: WarnerJan Veldhuis
> Priority: Minor
>
> Menu is not I18N-able. I have created a patch that fixes that. Here's an example of how
to set a messagekey in menu.xml, that corresponds to an item in the messageresources.
> The message attribute tells the menu which key should be used to get the text from the
message resources. (The $path variable can be used as well, since I adjusted the writeMenu
VM macro to use: #evaluate($submenu) instead of $submenu itself. Velocity now supports #evaluate
to evaluate a string that contains VM directives )
> <menu>
> <menu label="Home" path="/home.htm">
> <menu message="menu_logoff" path="$path?actionLink=logoff" roles="SU, DU,
VU, WU"/>
> </menu>
> </menu>
> The setParent method is overridden because the parent is needed to access the page's
message resources. It will also recursively descend into the children as well. Once you add
the menu to the page using Page.addControl(Menu.getRootMenu(new MyAccessController())); the
page is set as parent for all menuitems.
> Attribute message takes precedence over attribute label. If both are set, message is
the attribute used.
> So there you go. I18N for Menu :)
> Index: Menu.java
> ===================================================================
> --- Menu.java (revision 831895)
> +++ Menu.java (working copy)
> @@ -244,6 +244,9 @@
> /** The menu display label. */
> protected String label;
>
> + /** The message key to be used from the click-controls.properties or click-page.properties
*/
> + protected String messageKey;
> +
> /**
> * The list of valid page paths. If any of these page paths match the
> * current request then the Menu item will be selected.
> @@ -335,7 +338,9 @@
> setAccessController(accessController);
>
> setLabel(menuElement.getAttribute("label"));
> -
> +
> + setMessageKey(menuElement.getAttribute("message"));
> +
> setImageSrc(menuElement.getAttribute("imageSrc"));
>
> setPath(menuElement.getAttribute("path"));
> @@ -846,12 +851,20 @@
>
> buffer.elementEnd();
>
> - if (getLabel() != null) {
> + if ( StringUtils.isNotBlank(getMessageKey())) {
> + buffer.append(getMessage(getMessageKey()));
> + }
> + else if (getLabel() != null) {
> buffer.append(getLabel());
> }
>
> } else {
> - buffer.append(getLabel());
> + if (StringUtils.isNotBlank(getMessageKey())) {
> + buffer.append(getMessage(getMessageKey()));
> + }
> + else {
> + buffer.append(getLabel());
> + }
> }
>
> buffer.elementEnd("a");
> @@ -947,4 +960,23 @@
> return menu;
> }
>
> + public String getMessageKey() {
> + return messageKey;
> + }
> +
> + public void setMessageKey(String messageKey) {
> + this.messageKey = messageKey;
> + }
> +
> + /**
> + * @see org.apache.click.Control#setParent(Object)
> + * Sets the parent for this menu. This will automatically set the parent for the
children as well.
> + * @param parent The parent
> + */
> + public void setParent(Object parent) {
> + super.setParent(parent);
> + for (Object child : children) {
> + ((Menu) child).setParent(parent);
> + }
> + }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink updated CLK-405:
------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: CLK-592
> Menu improvements - allow setting the cache strategy.
> -----------------------------------------------------
>
> Key: CLK-405
> URL: https://issues.apache.org/jira/browse/CLK-405
> Project: Click
> Issue Type: Sub-task
> Components: extras
> Reporter: Demetrios Kyriakis
>
> Please improve the Menu Control, by allowing the user to set the chache stragety.
> Right now the cache strategy seems to be "application" (or JVM instance) only.
> This is very limiting, making the existing Menu Control useless for most user applications,
thus forcing the users
> to make their own menu controls (or the hack the original one).
> Please allow setting the cache strategy also to "session", and "request" (or "page" if
the page is stateful).
> (even if the default remains to "application" - the ensure the compatibility with existing
applications).
> Thank you,
> Demetrios.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink updated CLK-591:
------------------------------
Issue Type: Sub-task (was: Wish)
Parent: CLK-592
> I18N for Menu control
> ---------------------
>
> Key: CLK-591
> URL: https://issues.apache.org/jira/browse/CLK-591
> Project: Click
> Issue Type: Sub-task
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: WarnerJan Veldhuis
> Priority: Minor
>
> Menu is not I18N-able. I have created a patch that fixes that. Here's an example of how
to set a messagekey in menu.xml, that corresponds to an item in the messageresources.
> The message attribute tells the menu which key should be used to get the text from the
message resources. (The $path variable can be used as well, since I adjusted the writeMenu
VM macro to use: #evaluate($submenu) instead of $submenu itself. Velocity now supports #evaluate
to evaluate a string that contains VM directives )
> <menu>
> <menu label="Home" path="/home.htm">
> <menu message="menu_logoff" path="$path?actionLink=logoff" roles="SU, DU,
VU, WU"/>
> </menu>
> </menu>
> The setParent method is overridden because the parent is needed to access the page's
message resources. It will also recursively descend into the children as well. Once you add
the menu to the page using Page.addControl(Menu.getRootMenu(new MyAccessController())); the
page is set as parent for all menuitems.
> Attribute message takes precedence over attribute label. If both are set, message is
the attribute used.
> So there you go. I18N for Menu :)
> Index: Menu.java
> ===================================================================
> --- Menu.java (revision 831895)
> +++ Menu.java (working copy)
> @@ -244,6 +244,9 @@
> /** The menu display label. */
> protected String label;
>
> + /** The message key to be used from the click-controls.properties or click-page.properties
*/
> + protected String messageKey;
> +
> /**
> * The list of valid page paths. If any of these page paths match the
> * current request then the Menu item will be selected.
> @@ -335,7 +338,9 @@
> setAccessController(accessController);
>
> setLabel(menuElement.getAttribute("label"));
> -
> +
> + setMessageKey(menuElement.getAttribute("message"));
> +
> setImageSrc(menuElement.getAttribute("imageSrc"));
>
> setPath(menuElement.getAttribute("path"));
> @@ -846,12 +851,20 @@
>
> buffer.elementEnd();
>
> - if (getLabel() != null) {
> + if ( StringUtils.isNotBlank(getMessageKey())) {
> + buffer.append(getMessage(getMessageKey()));
> + }
> + else if (getLabel() != null) {
> buffer.append(getLabel());
> }
>
> } else {
> - buffer.append(getLabel());
> + if (StringUtils.isNotBlank(getMessageKey())) {
> + buffer.append(getMessage(getMessageKey()));
> + }
> + else {
> + buffer.append(getLabel());
> + }
> }
>
> buffer.elementEnd("a");
> @@ -947,4 +960,23 @@
> return menu;
> }
>
> + public String getMessageKey() {
> + return messageKey;
> + }
> +
> + public void setMessageKey(String messageKey) {
> + this.messageKey = messageKey;
> + }
> +
> + /**
> + * @see org.apache.click.Control#setParent(Object)
> + * Sets the parent for this menu. This will automatically set the parent for the
children as well.
> + * @param parent The parent
> + */
> + public void setParent(Object parent) {
> + super.setParent(parent);
> + for (Object child : children) {
> + ((Menu) child).setParent(parent);
> + }
> + }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[ https://issues.apache.org/jira/browse/CLK-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Schellink updated CLK-407:
------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: CLK-592
> Menu improvements - more properties: enable/disable, show/hide
> ---------------------------------------------------------------
>
> Key: CLK-407
> URL: https://issues.apache.org/jira/browse/CLK-407
> Project: Click
> Issue Type: Sub-task
> Components: extras
> Reporter: Demetrios Kyriakis
> Assignee: Adrian A.
>
> Please improve the Menu Control, by allowing the user to show/hide menu items, and also
to enable/disable them.
> Right now, this is not possible at all with the Menu Control :(.
> This is very limiting, making the existing Menu Control useless for most user applications,
thus forcing the users
> to make their own menu controls (or the hack the original one).
> There's no need for these properties to be present in menu.xml, since their role is mostly
at runtime:
> - enable/disable would allow to enable or disable a menu item (so to show it but make
it unclickable).
> - show/hide would allow to to show and hide menu items (of course if the user doesn't
have a specific role, the menu will be hidden).
> Regarding the API, it would be important to have practical methods for hiding and disabling
menu items:
> something like Menu#hide(Menu item) would not be very practical since in most cases the
"item" reference is not present
> so it should be Menu#hide(String path), and when applied, to seach this in the children
items too.
> Another improvement would be if the Menu Click control would use Link Controls for the
items (since that's what they are).
> Thank you,
> Demetrios.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.