incubator-clerezza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Story <henry.st...@bblfish.net>
Subject Re: [VOTE] Accept the proposed patch of CLEREZZA-540
Date Sun, 29 May 2011 18:16:45 GMT

On 28 May 2011, at 08:55, Tsuyoshi Ito wrote:

> Dear all
> 
> If no existing API will be changed:

Well the closing of 540 would also officially close 544 (which is still closed waiting for
540 to be closed
even though officially this is not a legal Apache maneuvre). And 544 does changes quite an
important api.

It adds a new method to CallbackRenderer

  public void render(UriRef resource, GraphNode context, String mode,
                     OutputStream os) throws IOException;

I am not against such an addition were it not for the way GraphNodeProvider is implemented
currently.
So if you look you will find that CallbackRendererImpl.java  has implemented the above method
like this

   @Override
+    public void render(final UriRef resource, GraphNode context, String mode,
+            OutputStream os) throws IOException {
+        final GraphNode resourceNode = AccessController.doPrivileged( new PrivilegedAction<GraphNode>()
{
+                    @Override
+                    public GraphNode run() {
+                        return graphNodeProvider.get(resource);
+                    }
+                });
+        render(resourceNode, context, mode, os);
+    }


Now this means that the GraphNodeProvider is not just a package for some of Reto's pet projects,
but
will be central to the working of Clerezza.  In which case the issue of the efficiency of
it and the
decisions it makes on what is authoritative should be considered more intently it seems to
me.

Henry


> 
> +1
> 
> Cheers
> Tsuy

Social Web Architect
http://bblfish.net/


Mime
View raw message