incubator-clerezza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Story <henry.st...@bblfish.net>
Subject Re: Reopening and redefining of CLEREZZA-531
Date Thu, 19 May 2011 14:44:29 GMT

On 19 May 2011, at 16:33, Reto Bachmann-Gmuer wrote:

> Hi Henry
> 
> CLEREZZA-531 was a very legitimate issue as it addressed major regression.
> 
> I proposed a patch which did solve the issue and closed the issue. You
> may disagree with this patch and reopen the issue but I don't think
> there is a reason to redefine the issue.
> 
> I thought my solution was in your interest to remove the troublesome
> (and never accepted) code of CLEREZZA-463 while leaving most of the
> useful stuff.  The alternative  would have been to ask you to revert
> CLEREZZA-463, this would have my task to resolve CLEREZZA-531 much
> easier.

That may be but the title is a complete misnomer. What you really were
doing was changing WebProxy. If the naming had been the only issue
then you could have just changed the name in the other code.

You could also have openened an issue for your new WebProxy and then
added that on one commit.

Then there could have been an issue to move from one to the other.

That is just what  your recent guidance on only doing small precise changes
would ammount to.

But frankly I think we can be a bit more flexible here.  The point is to
get moving and not waste time in procedures. So the best is just to change
the name of the issue, to make it do what your fix did.

> 
> So please
> 
> - reset the issue to the original and either
> 
> and either
> 
> - close the issue again
> 
> or
> 
> - oppose to my patch, in which case I'll revert the changes ask you to
> revert all your patches for CLEREZZA-463 and the resubmit the changes
> that are still relevant. The code in trunnk will look basically the
> same (apart that some accesses to the WebProxy from
> accountcontrolpanel and foafssl.test will be gone) but In this case
> you could no longer argue the solution to CLEREZZA-531 goes beyond the
> scope of the issue.

I don't have time for this nonsense. I don't think you are paying me
to work on this, are you? And I think I remember you renaming a few issues
before hand yourself.

Henry

> 
> Thank you
> 
> Reto
> 
> 
> 
> 
> On Thu, May 19, 2011 at 3:33 PM, Henry Story (JIRA) <jira@apache.org> wrote:
>> 
>>    [ https://issues.apache.org/jira/browse/CLEREZZA-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036181#comment-13036181
]
>> 
>> Henry Story edited comment on CLEREZZA-531 at 5/19/11 1:33 PM:
>> ---------------------------------------------------------------
>> 
>> This issue is really about replacing the original WebProxy code, with a new WebProxy
based on TcManager.
>> It follows on a rather long debate on the mailing list on "how to name things with
IRIs"
>> 
>>   http://mail-archives.apache.org/mod_mbox/incubator-clerezza-dev/201105.mbox/browser
>> 
>> keeping the original name of the issue to the "HTTP ERROR 500 on attempt to create
a new webid", does not explain the major refactoring done in the bug, as that could have done
just by a name adaption in the original WebProxy code.
>> 
>> (this is not to say I am against the refactoring. IT's just that it makes it difficult
to find the bug report and refer to it, as its name is a bit obscure)
>> 
>>      was (Author: bblfish):
>>    This issue is really about replacing the original WebProxy code, with a new WebProxy
based on TcManager.
>> It follows on a rather long debate on the mailing list on "how to name things with
IRIs"
>> 
>>   http://mail-archives.apache.org/mod_mbox/incubator-clerezza-dev/201105.mbox/browser
>> 
>> keeping the original name of the issue to the 500 code, does not explain the major
refactoring done in the bug, as that
>> could have done just by a name adaption in the original WebProxy code.
>> 
>>> Creating a WebProxy based on TC-Manager - HTTP ERROR: 500 on attempt to create
a new webid
>>> ------------------------------------------------------------------------------------------
>>> 
>>>                 Key: CLEREZZA-531
>>>                 URL: https://issues.apache.org/jira/browse/CLEREZZA-531
>>>             Project: Clerezza
>>>          Issue Type: Bug
>>>         Environment: platform.launcher.tdb-0.5-incubating-20110516.170205-73.jar
>>>            Reporter: Reto Bachmann-Gmür
>>>            Assignee: Reto Bachmann-Gmür
>>>            Priority: Blocker
>>> 
>>> Steps to reproduce the problem:
>>> 1) start clerezza
>>> 2) log in as admin
>>> 3) go to the account control panel
>>> 4) choose the profile tab
>>> 5) click on "create new Webid"
>>> 2011-05-16 22:17:43,226 [qtp20584312-74]  WARN [qtp20584312-74] (JaxRsHandler.java\:585)
- RuntimeException (with no exception mapper)
>>> java.lang.UnsupportedOperationException
>>>       at java.util.AbstractCollection.add(AbstractCollection.java:221)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.performAdd(AbstractTripleCollection.java:128)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.add(AbstractTripleCollection.java:112)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.add(AbstractTripleCollection.java:46)
>>>       at java.util.AbstractCollection.addAll(AbstractCollection.java:305)
>>>       at org.apache.clerezza.rdf.core.access.LockableMGraphWrapper.addAll(LockableMGraphWrapper.java:188)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel$$anon$3.run(ProfilePanel.scala:150)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel$$anon$3.run(ProfilePanel.scala:147)
>>>       at java.security.AccessController.doPrivileged(Native Method)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel.createNewWebId(ProfilePanel.scala:147)
>>>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>       at java.lang.reflect.Method.invoke(Method.java:597)
>>>       at org.apache.clerezza.triaxrs.RootResourceExecutorImpl.handleWithMethod(RootResourceExecutorImpl.java:469)
>>>       at org.apache.clerezza.triaxrs.RootResourceExecutorImpl.execute(RootResourceExecutorImpl.java:119)
>>>       at org.apache.clerezza.triaxrs.JaxRsHandler.handle(JaxRsHandler.java:503)
>>>       at org.wymiwyg.wrhapi.util.pathmappings.PathMappingHandler$RegisteredHandler.handle(PathMappingHandler.java:127)
>>>       at org.wymiwyg.wrhapi.util.pathmappings.PathMappingHandler.handle(PathMappingHandler.java:102)
>>>       at org.apache.clerezza.platform.security.auth.AuthenticatingFilter$1.run(AuthenticatingFilter.java:88)
>>>       at java.security.AccessController.doPrivileged(Native Method)
>>>       at javax.security.auth.Subject.doAsPrivileged(Subject.java:517)
>>>       at org.apache.clerezza.platform.security.auth.AuthenticatingFilter.handle(AuthenticatingFilter.java:84)
>>>       at org.wymiwyg.wrhapi.filter.impl.FilterRunner.handle(FilterRunner.java:56)
>>>       at org.apache.clerezza.platform.xhtml2html.Xhtml2HtmlFilter.handle(Xhtml2HtmlFilter.java:73)
>>>       at org.wymiwyg.wrhapi.filter.impl.FilterRunner.handle(FilterRunner.java:56)
>>>       at org.wymiwyg.wrhapi.osgi.OsgiWebServerFactory$1.service(OsgiWebServerFactory.java:78)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>>       at org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
>>>       at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:109)
>>>       at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:75)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>>       at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:546)
>>>       at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:483)
>>>       at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:228)
>>>       at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:956)
>>>       at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:411)
>>>       at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:188)
>>>       at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:891)
>>>       at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
>>>       at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:114)
>>>       at org.eclipse.jetty.server.Server.handle(Server.java:353)
>>>       at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:598)
>>>       at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1059)
>>>       at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:590)
>>>       at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:212)
>>>       at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:427)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:510)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint.access$000(SelectChannelEndPoint.java:34)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
>>>       at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:450)
>>>       at java.lang.Thread.run(Thread.java:662)
>>> 2011-05-16 22:17:43,227 [qtp20584312-74]  WARN [qtp20584312-74] (Slf4jLog.java\:50)
- /user/admin/profile/create-new-web-id
>>> java.lang.UnsupportedOperationException
>>>       at java.util.AbstractCollection.add(AbstractCollection.java:221)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.performAdd(AbstractTripleCollection.java:128)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.add(AbstractTripleCollection.java:112)
>>>       at org.apache.clerezza.rdf.core.impl.AbstractTripleCollection.add(AbstractTripleCollection.java:46)
>>>       at java.util.AbstractCollection.addAll(AbstractCollection.java:305)
>>>       at org.apache.clerezza.rdf.core.access.LockableMGraphWrapper.addAll(LockableMGraphWrapper.java:188)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel$$anon$3.run(ProfilePanel.scala:150)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel$$anon$3.run(ProfilePanel.scala:147)
>>>       at java.security.AccessController.doPrivileged(Native Method)
>>>       at org.apache.clerezza.platform.accountcontrolpanel.ProfilePanel.createNewWebId(ProfilePanel.scala:147)
>>>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>>       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>>       at java.lang.reflect.Method.invoke(Method.java:597)
>>>       at org.apache.clerezza.triaxrs.RootResourceExecutorImpl.handleWithMethod(RootResourceExecutorImpl.java:469)
>>>       at org.apache.clerezza.triaxrs.RootResourceExecutorImpl.execute(RootResourceExecutorImpl.java:119)
>>>       at org.apache.clerezza.triaxrs.JaxRsHandler.handle(JaxRsHandler.java:503)
>>>       at org.wymiwyg.wrhapi.util.pathmappings.PathMappingHandler$RegisteredHandler.handle(PathMappingHandler.java:127)
>>>       at org.wymiwyg.wrhapi.util.pathmappings.PathMappingHandler.handle(PathMappingHandler.java:102)
>>>       at org.apache.clerezza.platform.security.auth.AuthenticatingFilter$1.run(AuthenticatingFilter.java:88)
>>>       at java.security.AccessController.doPrivileged(Native Method)
>>>       at javax.security.auth.Subject.doAsPrivileged(Subject.java:517)
>>>       at org.apache.clerezza.platform.security.auth.AuthenticatingFilter.handle(AuthenticatingFilter.java:84)
>>>       at org.wymiwyg.wrhapi.filter.impl.FilterRunner.handle(FilterRunner.java:56)
>>>       at org.apache.clerezza.platform.xhtml2html.Xhtml2HtmlFilter.handle(Xhtml2HtmlFilter.java:73)
>>>       at org.wymiwyg.wrhapi.filter.impl.FilterRunner.handle(FilterRunner.java:56)
>>>       at org.wymiwyg.wrhapi.osgi.OsgiWebServerFactory$1.service(OsgiWebServerFactory.java:78)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>>       at org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
>>>       at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:109)
>>>       at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:75)
>>>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:847)
>>>       at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:546)
>>>       at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:483)
>>>       at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:228)
>>>       at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:956)
>>>       at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:411)
>>>       at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:188)
>>>       at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:891)
>>>       at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
>>>       at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:114)
>>>       at org.eclipse.jetty.server.Server.handle(Server.java:353)
>>>       at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:598)
>>>       at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1059)
>>>       at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:590)
>>>       at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:212)
>>>       at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:427)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:510)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint.access$000(SelectChannelEndPoint.java:34)
>>>       at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
>>>       at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:450)
>>>       at java.lang.Thread.run(Thread.java:662)
>> 
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>> 

Social Web Architect
http://bblfish.net/


Mime
View raw message