incubator-clerezza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reto Bachmann-Gmuer <reto.bachm...@trialox.org>
Subject Your commit and RichGraphNode
Date Tue, 15 Mar 2011 19:03:30 GMT
Hi Henry

Could you please fix yesterday's commit? There are still experiments and
discussion in it.

One discussion (taken from
rdf.scala.utils/src/main/scala/org/apache/clerezza/rdf/scala/utils/RichGraphNode.scala):

/* because it is tedious to wrap nodes as happens in a lot of code.

That's why there are dynamic conversions, the Preamble Object converts any
GraphNode to RichGraphNode, instances of the preamble class also convert
Resources (such as UriRefs) to RichGraphNodes.
         *
         * todo: does one really need to create the graph node? Is there a
reason this is passed ike that,
What do you suggest, RichGraphNode not to be a subclass of GraphNode? Why?

         * todo: or was that just a quick hack? If it is because we don't
want to use any of the superclass implementations
Not sure what you're refreing too, RichGraphNode doesn't reimplement any of
the superclass methods
         * todo: then it would be worth creating an interface above
GraphNode and implementing the interface instead...
I see no need for this.


Cheers,
reto

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message