Return-Path: Delivered-To: apmail-incubator-clerezza-dev-archive@minotaur.apache.org Received: (qmail 60765 invoked from network); 11 Oct 2010 17:21:42 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Oct 2010 17:21:42 -0000 Received: (qmail 13377 invoked by uid 500); 11 Oct 2010 17:21:42 -0000 Delivered-To: apmail-incubator-clerezza-dev-archive@incubator.apache.org Received: (qmail 13346 invoked by uid 500); 11 Oct 2010 17:21:42 -0000 Mailing-List: contact clerezza-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: clerezza-dev@incubator.apache.org Delivered-To: mailing list clerezza-dev@incubator.apache.org Received: (qmail 13335 invoked by uid 99); 11 Oct 2010 17:21:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Oct 2010 17:21:41 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Oct 2010 17:21:34 +0000 Received: by yxj4 with SMTP id 4so1016470yxj.6 for ; Mon, 11 Oct 2010 10:21:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.3.65 with SMTP id 1mr2625036icn.78.1286817672716; Mon, 11 Oct 2010 10:21:12 -0700 (PDT) Sender: reto@trialox.org Received: by 10.231.36.73 with HTTP; Mon, 11 Oct 2010 10:21:12 -0700 (PDT) X-Originating-IP: [217.71.247.242] In-Reply-To: <20101011082707.6C75E238899C@eris.apache.org> References: <20101011082707.6C75E238899C@eris.apache.org> Date: Mon, 11 Oct 2010 19:21:12 +0200 X-Google-Sender-Auth: Wwl4IpSV2L_zuYglWbTfdPsgSZM Message-ID: Subject: Re: svn commit: r1021280 - /incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.platform.usermanager/src/main/java/org/apache/clerezza/platform/usermanager/UserManagerImpl.java From: Reto Bachmann-Gmuer To: clerezza-dev@incubator.apache.org Cc: clerezza-commits@incubator.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable HI Manuel This patch effectively causes the user to require write access where they previously (and logical) only needed read-access. Maybe getUnsecuredMGraph should be redefined (and possibly renamed accordingly) to return a read-only-mgraph if write right cannot be granted. Cheers, reto On Mon, Oct 11, 2010 at 10:27 AM, wrote: > Author: mir > Date: Mon Oct 11 08:27:07 2010 > New Revision: 1021280 > > URL: http://svn.apache.org/viewvc?rev=3D1021280&view=3Drev > Log: > CLEREZZA-316: service depends on existence of system graph. Therefore get= ting the system graph over @Reference again > > Modified: > =C2=A0 =C2=A0incubator/clerezza/trunk/org.apache.clerezza.parent/org.apac= he.clerezza.platform.usermanager/src/main/java/org/apache/clerezza/platform= /usermanager/UserManagerImpl.java > > Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.= clerezza.platform.usermanager/src/main/java/org/apache/clerezza/platform/us= ermanager/UserManagerImpl.java > URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.cle= rezza.parent/org.apache.clerezza.platform.usermanager/src/main/java/org/apa= che/clerezza/platform/usermanager/UserManagerImpl.java?rev=3D1021280&r1=3D1= 021279&r2=3D1021280&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerez= za.platform.usermanager/src/main/java/org/apache/clerezza/platform/usermana= ger/UserManagerImpl.java (original) > +++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerez= za.platform.usermanager/src/main/java/org/apache/clerezza/platform/usermana= ger/UserManagerImpl.java Mon Oct 11 08:27:07 2010 > @@ -30,7 +30,7 @@ import java.util.Iterator; > =C2=A0import java.util.List; > =C2=A0import java.util.Set; > =C2=A0import java.util.concurrent.locks.Lock; > -import org.apache.clerezza.platform.Constants; > +import org.apache.clerezza.platform.config.SystemConfig; > =C2=A0import org.apache.felix.scr.annotations.Component; > =C2=A0import org.apache.felix.scr.annotations.Reference; > =C2=A0import org.apache.felix.scr.annotations.Service; > @@ -45,6 +45,7 @@ import org.apache.clerezza.rdf.core.Reso > =C2=A0import org.apache.clerezza.rdf.core.Triple; > =C2=A0import org.apache.clerezza.rdf.core.UriRef; > =C2=A0import org.apache.clerezza.rdf.core.access.LockableMGraph; > +import org.apache.clerezza.rdf.core.access.SecuredMGraph; > =C2=A0import org.apache.clerezza.rdf.core.access.TcManager; > =C2=A0import org.apache.clerezza.rdf.core.impl.PlainLiteralImpl; > =C2=A0import org.apache.clerezza.rdf.core.impl.SimpleMGraph; > @@ -73,8 +74,11 @@ public class UserManagerImpl implements > > =C2=A0 =C2=A0 =C2=A0 =C2=A0private final Logger logger =3D LoggerFactory.= getLogger(getClass()); > > + =C2=A0 =C2=A0 =C2=A0 @Reference(target =3D SystemConfig.SYSTEM_GRAPH_FI= LTER) > + =C2=A0 =C2=A0 =C2=A0 private MGraph securedSystemGraph; > + > =C2=A0 =C2=A0 =C2=A0 =C2=A0private LockableMGraph getSystemGraph() { > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return tcManager.getMG= raph(Constants.SYSTEM_GRAPH_URI); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return ((SecuredMGraph= ) securedSystemGraph).getUnsecuredMGraph(); > =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > =C2=A0 =C2=A0 =C2=A0 =C2=A0@Override > > >