incubator-clerezza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hasan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLEREZZA-48) Enable an auto generated response to an HTTP OPTIONS request
Date Wed, 23 Dec 2009 09:19:29 GMT

    [ https://issues.apache.org/jira/browse/CLEREZZA-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793978#action_12793978
] 

Hasan commented on CLEREZZA-48:
-------------------------------

AutoGeneratedOptionsTest
- a short description (as comments) about the purpose of the test would be fine
  and refer to relevant sections in JAX-RS specification, e.g., 3.3.5
- suggest to rename the test class to AutoGeneratedResponseTest
  and the method name to testResponseToOptionsRequest
- suggest to avoid printing messages in test, use assert instead
  In this particular case, replace system.out.println with a variable assignment
  which can be later tested whether or not this variable should be assigned in
  specific test.
- for this test, it's not necessary to define propfind method, you can use existing
  http methods like GET, PUT, etc.


Review to be continued by Reto BG

> Enable an auto generated response to an HTTP OPTIONS request
> ------------------------------------------------------------
>
>                 Key: CLEREZZA-48
>                 URL: https://issues.apache.org/jira/browse/CLEREZZA-48
>             Project: Clerezza
>          Issue Type: Bug
>            Reporter: Agron Limani
>            Assignee: Reto Bachmann-Gmür
>         Attachments: AutoGeneratedOptionsTest.java, org.clerezza.apache.triaxrs-CLEREZZA-48.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message