Mailing-List: contact chukwa-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: chukwa-dev@hadoop.apache.org
Message-ID: <1222446492.1242271485647.JavaMail.jira@brutus>
Date: Wed, 13 May 2009 20:24:45 -0700 (PDT)
From: "Ari Rabkin (JIRA)" <jira@apache.org>
To: chukwa-dev@hadoop.apache.org
Subject: [jira] Commented: (CHUKWA-30) Remove HDFS flush & connection
 holding (Collector)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHUKWA-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709253#action_12709253 ] 

Ari Rabkin commented on CHUKWA-30:
----------------------------------

Looks promising.  Couple comments:

- Why are seqFileWriter and the associated lock static?  This makes it harder to unit test and seems unnecessary.

- Why aren't there unit tests?

- Can you add the necessary/optional conf options to chukwa-collector-conf.xml.template?

- What's the point of doing local buffering if it doesn't give us any better reliability semantics?

> Remove HDFS flush & connection holding (Collector)
> --------------------------------------------------
>
>                 Key: CHUKWA-30
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-30
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>            Reporter: Jerome Boulon
>            Assignee: Jerome Boulon
>         Attachments: CHUKWA-30.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.