incubator-celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Broekhuis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CELIX-50) driverAttributes_getDriverId does not return DriverId
Date Thu, 18 Apr 2013 07:35:16 GMT

     [ https://issues.apache.org/jira/browse/CELIX-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Broekhuis resolved CELIX-50.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.0.2-incubating

Fixed this issue, could you please verify and close if all is ok?
---------------------------
Author: abroekhuis
Date: Thu Apr 18 07:31:36 2013
New Revision: 1469206

URL: http://svn.apache.org/r1469206
Log:
CELIX-50: Fixed small error in the driver attributes.

Modified:
    incubator/celix/trunk/device_access/device_access/private/src/driver_attributes.c
                
> driverAttributes_getDriverId does not return DriverId
> -----------------------------------------------------
>
>                 Key: CELIX-50
>                 URL: https://issues.apache.org/jira/browse/CELIX-50
>             Project: Celix
>          Issue Type: Bug
>    Affects Versions: 0.0.1-incubating, 0.0.2-incubating
>            Reporter: Bjoern Petri
>            Assignee: Alexander Broekhuis
>            Priority: Minor
>              Labels: device, driver
>             Fix For: 0.0.2-incubating
>
>
> I had some problems, when I was trying to publish two devices from one service and attach
two drivers of the same device category to it. 
> Well, I figured out, that the deviceManager_attachAlgorithm function was not able to
remove the already installed drivers from the manager->drivers list cause driverAttributes_getDriverId
always returned CELIX_ENOMEM. 
> Taking a look at the code (driverAttributes_getDriverId in device_access/device_access/private/src/driver_attributes.c),
I found:
> [...]
> char *id_prop = properties_get(properties, "DRIVER_ID")
> if (id_prop) {
>    status = CELIX_ENOMEM;
> }
> [...]
> which should probably be:
> [...]
> char *id_prop = properties_get(properties, "DRIVER_ID")
> if (id_prop == NULL) {
>    status = CELIX_ENOMEM;
> }
> [...]
> I would be glad if you shortly can confirm that, so I will create a patch. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message