incubator-celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bjoern Petri (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CELIX-50) driverAttributes_getDriverId does not return DriverId
Date Wed, 17 Apr 2013 12:39:16 GMT
Bjoern Petri created CELIX-50:
---------------------------------

             Summary: driverAttributes_getDriverId does not return DriverId
                 Key: CELIX-50
                 URL: https://issues.apache.org/jira/browse/CELIX-50
             Project: Celix
          Issue Type: Bug
    Affects Versions: 0.0.1-incubating, 0.0.2-incubating
            Reporter: Bjoern Petri
            Priority: Minor


I had some problems, when I was trying to publish two devices from one service and attach
two drivers of the same device category to it. 

Well, I figured out, that the deviceManager_attachAlgorithm function was not able to remove
the already installed drivers from the manager->drivers list cause driverAttributes_getDriverId
always returned CELIX_ENOMEM. 

Taking a look at the code, I found:

[...]
char *id_prop = properties_get(properties, "DRIVER_ID")

if (id_prop) {
   status = CELIX_ENOMEM;
}
[...]


which should probably be:


[...]
char *id_prop = properties_get(properties, "DRIVER_ID")

if (id_prop == NULL) {
   status = CELIX_ENOMEM;
}
[...]



I would be glad if you shortly can confirm that, so I will create a patch. 

 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message