incubator-celix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Broekhuis (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CELIX-33) Framework uses fmaxl, function not supported by some (ARM) compilers
Date Tue, 10 Apr 2012 08:42:23 GMT

     [ https://issues.apache.org/jira/browse/CELIX-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Broekhuis resolved CELIX-33.
--------------------------------------

    Resolution: Fixed
      Assignee: Alexander Broekhuis

Author: abroekhuis
Date: Tue Apr 10 08:38:20 2012
New Revision: 1311636

URL: http://svn.apache.org/viewvc?rev=1311636&view=rev
Log:
CELIX-33: fmaxl not supported on ARM

Modified:
   incubator/celix/trunk/framework/private/src/framework.c
                
> Framework uses fmaxl, function not supported by some (ARM) compilers
> --------------------------------------------------------------------
>
>                 Key: CELIX-33
>                 URL: https://issues.apache.org/jira/browse/CELIX-33
>             Project: Celix
>          Issue Type: Bug
>         Environment: Linux Ubuntu 64bit
>            Reporter: Jonathan Melissant
>            Assignee: Alexander Broekhuis
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The celix framework uses the function fmaxl. Since this is not supported in
> ucLibc 9.33 (which has been reported to uclibc as a bug), I noticed that
> the function was used to compare 2 longs (instead of 2 doubles), and
> therefore can be replaced by the following:
> // framework->nextBundleId = fmaxl(framework->nextBundleId,  id + 1); // original
> // FIXME: 20120405 CHANGED TO REMOVE UNDEFINED fmaxl problem. Check later if this "fix"
is acceptable
>            framework->nextBundleId = (framework->nextBundleId) > (id+1) ? (framework->nextBundleId)
: (id+1);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message