Mailing-List: contact user-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@cassandra.apache.org
Received-SPF: pass (nike.apache.org: domain of greghinkle@gmail.com designates
 209.85.220.172 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: MessagingService.sendOneWay sending blank bytes?
From: Greg Hinkle <greghinkle@gmail.com>
In-Reply-To: 
 <CALdd-zgU5e8dkA0no78e0ZK03XEgaAyS-Gmfe9JrNS7Q+5S6eA@mail.gmail.com>
Date: Fri, 23 Sep 2011 09:04:54 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <DA9258EA-78CE-4CC6-94EE-3398F74084CB@gmail.com>
References: <F4CC1C05-205E-428B-9DD8-68D6C83F07AB@gmail.com>
 <CALdd-zgU5e8dkA0no78e0ZK03XEgaAyS-Gmfe9JrNS7Q+5S6eA@mail.gmail.com>
To: user@cassandra.apache.org

Is it worth a back-port or at least switch to asByteArray for 0.8.7? =
It's a sizable amount of wasted network traffic and the fix seems pretty =
safe. (It's working for me)

Greg Hinkle

On Sep 23, 2011, at 3:32 AM, Jonathan Ellis wrote:

> Yes.  This is one of the things fixed for 1.0 in
> https://issues.apache.org/jira/browse/CASSANDRA-1788
>=20
> On Thu, Sep 22, 2011 at 11:16 PM, Greg Hinkle <greghinkle@gmail.com> =
wrote:
>> I noticed that on the 0.8 branch the implementation of =
MessagingService.sendOneWay is building up a DataOutputBuffer with a =
default size of 128 bytes, but then sending it as the full buffer no =
matter how many bytes the the data takes. I believe it should be calling =
DataOutputBuffer.asByteArray() or copying just up to the length() into =
the ByteBuffer. This means it appears to be wasting on around 40 to 80 =
bytes on every message. This really adds up in a big cluster.
>>=20
>> It looks like things are different in trunk, but can anyone confirm =
this bug in 0.8? Thanks.
>>=20
>>=20
>> Greg Hinkle
>>=20
>>=20
>=20
>=20
>=20
> --=20
> Jonathan Ellis
> Project Chair, Apache Cassandra
> co-founder of DataStax, the source for professional Cassandra support
> http://www.datastax.com