Mailing-List: contact user-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@cassandra.apache.org
Received-SPF: pass (nike.apache.org: domain of jbellis@gmail.com designates
 209.85.220.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=Zen5aIE8ITVKsvySwIym7ygXpMCDLx5RHBG8ntmSt4NinptcVtWR+GSoGE0h8biv2k
         0uIo/r2eIKY/1+tGiyyZYPZew6rvaciQcgvAwypCmhRRqur0On+eI22b9cBTaK2pmAaU
         tifMJTPWj2Cul8p3Kk3vcu6LTBTxG2cykuY6s=
MIME-Version: 1.0
In-Reply-To: 
 <6F8DF32E96493B44B00A17248867481E02C723@SZXEML505-MBS.china.huawei.com>
References: 
 <6F8DF32E96493B44B00A17248867481E02C6B7@SZXEML505-MBS.china.huawei.com>
 <C3691463-0C27-4F55-A421-07CA9199F548@thelastpickle.com>
 <6F8DF32E96493B44B00A17248867481E02C723@SZXEML505-MBS.china.huawei.com>
From: Jonathan Ellis <jbellis@gmail.com>
Date: Thu, 24 Mar 2011 09:11:45 -0500
Message-ID: <AANLkTikkBfLuLPw_58s0EM4hnm8nM_49HQsoqM4hbpPV@mail.gmail.com>
Subject: Re: result of get_indexed_slices() seems wrong
To: user@cassandra.apache.org
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: quoted-printable

it's unusual but valid to have an expression on a column w/ no metadata.

2011/3/24 Wangpei (Peter) <peter.wangpei@huawei.com>:
> Thanks aaron.
>
> Maybe we need to do more check at ThriftValidation.validateIndexClauses()=
,
> add this:
>
>         Map<ByteBuffer, ColumnDefinition> colDefs =3D
> DatabaseDescriptor.getTableDefinition(keyspace).cfMetaData().get(columnFa=
mily).getColumn_metadata();
>
>         for (IndexExpression expression : index_clause.expressions)
>
>         {
>
>             if (!colDefs.containsKey(expression.column_name))
>
>                 throw new InvalidRequestException("No column definition f=
or
> " + expression.column_name);
>
>         }
>
>
>
>
>
> =B7=A2=BC=FE=C8=CB: aaron morton [mailto:aaron@thelastpickle.com]
> =B7=A2=CB=CD=CA=B1=BC=E4: 2011=C4=EA3=D4=C224=C8=D5 12:24
> =CA=D5=BC=FE=C8=CB: user@cassandra.apache.org
> =D6=F7=CC=E2: Re: result of get_indexed_slices() seems wrong
>
>
>
> Looks like this https://issues.apache.org/jira/browse/CASSANDRA-2347
>
>
>
> From this
> discussion http://www.mail-archive.com/user@cassandra.apache.org/msg11291=
.html
>
>
>
>
>
> Aaron
>
>
>
> On 24 Mar 2011, at 17:17, Wangpei (Peter) wrote:
>
> Hi,
>
>
>
> This problem occurs when the clause has multi expression and a expression
> with operator other than EQ.
>
> Is anyone meet the same problem?
>
>
>
> I trace the code, and seen this at ColumnFamilyStore.satisfies() method:
>
>             int v =3D data.getComparator().compare(column.value(),
> expression.value);
>
> It seems when I need the type of column value here, it use the type of my
> column names which is UTF8Type, so give the wrong result.
>
> To fix it, the expression needs a optional "comparator_type" attribute, t=
hen
> satisfies() can get the correct type to compare.
>
> pls point out if I am wrong.
>
>
>
>
>
>


--=20
Jonathan Ellis
Project Chair, Apache Cassandra
co-founder of DataStax, the source for professional Cassandra support
http://www.datastax.com