Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Received-SPF: pass (nike.apache.org: domain of j.zach.richardson@gmail.com
 designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CALHkrw9x2F6zCrXo3Uvgredg+eVTPWY7xCwf4sWGrQOynOT2iQ@mail.gmail.com>
References: 
 <CAH53hK2OuudbQXMqrQHQ-Ra+8eHy0S_+tzcwx74Er-KGMm5G=A@mail.gmail.com>
	<CALdd-zgs+SY3oZZPvR01W+JTf=PTthBqUjjc5yQioXwvsCS0eg@mail.gmail.com>
	<CAHBoXAV=9a3N=093Fi1bcC8r_mu5gqdbBgvOsQL=PyaSzAVHoA@mail.gmail.com>
	<CALHkrw9x2F6zCrXo3Uvgredg+eVTPWY7xCwf4sWGrQOynOT2iQ@mail.gmail.com>
Date: Wed, 26 Oct 2011 15:18:20 -0500
Message-ID: 
 <CAH53hK3KgycetePWuQGdHxyDAZEgMHEOHiPfTufPRUsCNqL41A@mail.gmail.com>
Subject: Re: Trying to write tests for CASSANDRA-3127 (Internode Compression)
From: Zach Richardson <j.zach.richardson@gmail.com>
To: dev@cassandra.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Nick,

Thanks for the reply!

I ended up creating a custom IVerbHandler to receive the messages from
MessagingService, and when I created messages, I set their from field
to an address !=3D localhost, so they did not get optimized.  This
appeared to work!

Thanks again.

Zach

On Mon, Oct 24, 2011 at 10:25 AM, Nick Bailey <nick@datastax.com> wrote:
> Not sure if you saw this, but org.apache.cassandra.net.sink has a
> SinkManager class and an interface for implementing message sinks. Basica=
lly
> it lets you catch messages as they are being sent or received by
> MessagingService.
>
> Could be useful, and is used in a couple other tests.
>
> On Sun, Oct 23, 2011 at 11:54 AM, Zach Richardson <zach@raveldata.com>wro=
te:
>
>> Thanks,
>>
>> Will give these a shot.
>>
>> On Sun, Oct 23, 2011 at 11:18 AM, Jonathan Ellis <jbellis@gmail.com>
>> wrote:
>>
>> > I see a couple options.
>> >
>> > StorageProxy has this constant:
>> >
>> > =A0 =A0private static final boolean OPTIMIZE_LOCAL_REQUESTS =3D true; =
//
>> > set to false to test messagingservice path on single node
>> >
>> > So, you could make it an instance variable and create a SP object with
>> > it set to false for tests.
>> >
>> > Or, you could do a test using ccm for multinode control, as in the
>> > long_read.sh test on
>> > https://issues.apache.org/jira/browse/CASSANDRA-3303.
>> >
>> > On Fri, Oct 21, 2011 at 4:28 PM, Zach Richardson
>> > <j.zach.richardson@gmail.com> wrote:
>> > > Hi All,
>> > >
>> > > I have been working on an implementation for internode compression
>> > > (CASSANDRA-3127.) https://issues.apache.org/jira/browse/CASSANDRA-31=
27
>> > >
>> > > I have written code that "works," but I'm looking for some advice on
>> > > how to write unit tests for it. =A0At the moment it compresses where=
:
>> > >
>> > > interrnode_message_compression_threshold > 0 means it compress
>> > > messages larger than it
>> > > compresses all messags if it is =3D=3D 0
>> > > and compresses none if less than 0
>> > >
>> > > The code itself has been tested in an environment outside of cassand=
ra
>> > > (i.e. a few mock classes, and a heavily modified OutboundTcpConnecti=
on
>> > > and IncomingTcpConnection.) and inside of Cassandra all of the curre=
nt
>> > > unit tests are passing.
>> > >
>> > > Since I can't inject a mocked MessagingService into
>> > > IncomingTcpConnection, I'm guessing I have to do the testing from th=
e
>> > > outside of MessagingService, but the MessagingService itself checks =
to
>> > > see if you are sending messages to yourself, and doesn't put them ov=
er
>> > > the connection. =A0Are there any tricks to letting me mock different
>> > > endpoints from within a unit test?
>> > >
>> > > Can this only be tested in a distributed fashion at the OS level?
>> > >
>> > > Also the internode_message_compression_threshold is set through the
>> > > cassandra.yaml file--is it possible to set these properties at
>> > > runtime? =A0Can I just change the public entry for it in the static
>> > > Config class directly, or will that break other things?
>> > >
>> > > Thanks for you help and time,
>> > >
>> > > Zach
>> > >
>> >
>> >
>> >
>> > --
>> > Jonathan Ellis
>> > Project Chair, Apache Cassandra
>> > co-founder of DataStax, the source for professional Cassandra support
>> > http://www.datastax.com
>> >
>>
>>
>>
>> --
>> Zach Richardson
>> Ravel, Co-founder
>> Austin, TX
>> zach@raveldata.com
>> 512.825.6031
>>
>