incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Edward Capriolo <edlinuxg...@gmail.com>
Subject Re: ByteBuffers and StorageProxy
Date Tue, 11 Oct 2011 16:58:00 GMT
On Tue, Oct 11, 2011 at 12:25 PM, Todd Burruss <bburruss@expedia.com> wrote:

> My recent bug was that I was sending a zero length ByteBuffer (because I
> forgot to flip) for a column name.  The problem I have is that the insert
> was accepted by the server.  Should an exception be thrown?  The end result
> of allowing the insert is that the server will not restart if the data is
> still in the commit log (and maybe later too, not sure).
>
>
You may not have hit this at the thrift layer, because the AbstractTypes
have validation methods. Since StorageProxy is the "expert" interface having
redundant checks might cause code bloat. Open a jira and put in the patch.
The worse that can happen is it gets -1 ed.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message