Return-Path: 
 <dev-return-4434-apmail-cassandra-dev-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-dev-archive@www.apache.org
Delivered-To: apmail-cassandra-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9D77176A8
	for <apmail-cassandra-dev-archive@www.apache.org>;
 Tue, 30 Aug 2011 01:56:50 +0000 (UTC)
Received: (qmail 25407 invoked by uid 500); 30 Aug 2011 01:56:49 -0000
Delivered-To: apmail-cassandra-dev-archive@cassandra.apache.org
Received: (qmail 25316 invoked by uid 500); 30 Aug 2011 01:56:48 -0000
Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cassandra.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cassandra.apache.org>
List-Post: <mailto:dev@cassandra.apache.org>
List-Id: <dev.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list dev@cassandra.apache.org
Received: (qmail 25304 invoked by uid 99); 30 Aug 2011 01:56:48 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 01:56:48 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of wfshaw@gmail.com designates
 74.125.83.44 as permitted sender)
Received: from [74.125.83.44] (HELO mail-gw0-f44.google.com) (74.125.83.44)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 01:56:41 +0000
Received: by gwb20 with SMTP id 20so6195776gwb.31
        for <dev@cassandra.apache.org>; Mon, 29 Aug 2011 18:56:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=content-type:mime-version:subject:from:in-reply-to:date
         :content-transfer-encoding:message-id:references:to:x-mailer;
        bh=8WlIsK2Ke3yCMcjOOqXZxeyb1sg0tvtwnTI2L9nxXZw=;
        b=SqVsCsSWQaywNnJIHmQILhr+qdTXBVoghxs+6eJMDdIfl9YD03algsR0tfyiHVFoWE
         9sfIke3FJhUxovafNhdveeJiZ22joSLK+A3Zj3ezl3qvwjK0/rzYj3YOvqa5Y+7TDvSL
         l3PblUA5cgCHzeYVGyv0lGe6kXQqX0vVn3ODM=
Received: by 10.236.80.66 with SMTP id j42mr29214151yhe.98.1314669381147;
        Mon, 29 Aug 2011 18:56:21 -0700 (PDT)
Received: from [10.0.1.106] (adsl-184-36-148-29.asm.bellsouth.net
 [184.36.148.29])
        by mx.google.com with ESMTPS id j45sm395340yhe.36.2011.08.29.18.56.19
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 29 Aug 2011 18:56:20 -0700 (PDT)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1244.3)
Subject: Re: CqlResult in CassandraConnection
From: Rick Shaw <wfshaw@gmail.com>
In-Reply-To: <1314598660.36440.YahooMailNeo@web32507.mail.mud.yahoo.com>
Date: Mon, 29 Aug 2011 21:56:19 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <C6E17180-29BF-4D5B-BC64-AA1641A8CE6E@gmail.com>
References: <1314521276.99952.YahooMailNeo@web32502.mail.mud.yahoo.com>
 <CAL35Oi3C4dVaoYdmpE+cqdrcZWiM0a6-fCczHD6eCj1OTrOFyg@mail.gmail.com>
 <71532149-2F19-4F3B-AB9E-AEECF87DB508@gmail.com>
 <1314552835.1000.YahooMailNeo@web32503.mail.mud.yahoo.com>
 <E87512E3-298C-4AFB-8535-029DF95BBE27@gmail.com>
 <1314598660.36440.YahooMailNeo@web32507.mail.mud.yahoo.com>
To: dev@cassandra.apache.org,
 Vivek Mishra <vivek.mishra@yahoo.com>
X-Mailer: Apple Mail (2.1244.3)

No. I know of none. I will however, make sure the the abstract keyword =
is added to the classes you have mentioned.



On Aug 29, 2011, at 2:17 AM, Vivek Mishra wrote:

> Thanks Rick.
>=20
>=20
> As to class level hierarchy, I am not sure I understand the reference? =
Could you elaborate?
>=20
> <Vivek> As we have got 1 super class and sub class in place for ( =
AbstractCassandraConnection,AbstractResultSet and AbstractStatement). So =
thought to ask for if any other implementation is on roadmap? </vivek>
>=20
>=20
> Vivek
>=20
>=20
>=20
> ________________________________
> From: Rick Shaw <wfshaw@gmail.com>
> To: dev@cassandra.apache.org; Vivek Mishra <vivek.mishra@yahoo.com>
> Sent: Monday, August 29, 2011 12:59 AM
> Subject: Re: CqlResult in CassandraConnection
>=20
> The reason they are set up that was is to clearly delineate between =
methods that there are no plans to implement any time in the near =
future; it minimizes the distraction in the classes that get a lot of =
activity. It is not necessary, but it was done that way when I started =
looking at the code and I recognized it as a clever approach and I =
followed its example. As to being confusing, I guess the abstract =
keyword was inadvertently omitted along the way and got propagated; but =
the intended effect is not hampered by the omission. I'll clean it up =
with the addition of the keyword to improve on its clarity.
>=20
> As to class level hierarchy, I am not sure I understand the reference? =
Could you elaborate?
>=20
> As to plans: Broad plans for 1.0 timeframe target are published in =
CASSANDRA-2876. The implementation of the prepared statement =
improvements (CASSANDRA-2885) is waiting on required support of CQL in =
various forms.=20
>=20
> I am also unclear as to what you are asking for in the final =
paragraph? Changes in each of those classes is inevitable to support new =
features but there are no plans (by me) for any other  (alternate) =
classes. Perhaps you are implying they could be marked final? Note =
CassandraPreparedStatement is a sub-class of CassandraStatement.
>=20
> On Aug 28, 2011, at 1:33 PM, Vivek Mishra wrote:
>=20
>> I was looking at AbstractCassandraConnection,AbstractResultSet and =
AbstractStatement classes. Name looks to me quite confusing as none of =
them is an abstract class.  1 more thin, any specific reason for =
creating class level hierarchy?=20
>> -2876
>> Plans for any other implementation/s of CassandraConnection, =
ResultSet and Statement sub class?
>>=20
>> Vovel
>>=20
>>=20
>>=20
>> ________________________________
>> From: Rick Shaw <wfshaw@gmail.com>
>> To: dev@cassandra.apache.org
>> Cc: Vivek Mishra <vivek.mishra@yahoo.com>
>> Sent: Sunday, August 28, 2011 9:39 PM
>> Subject: Re: CqlResult in CassandraConnection
>>=20
>> The class itself is not public, so it is generally protected from =
misuse, but it is a good recommendation to remove the public modifier on =
those non-interface imethods as well. I'll see to it.
>>=20
>> On Aug 28, 2011, at 11:35 AM, Eric Evans wrote:
>>=20
>>> On Sun, Aug 28, 2011 at 3:47 AM, Vivek Mishra =
<vivek.mishra@yahoo.com> wrote:
>>>> Recently i can see changes made in jdbc connection API.
>>>>=20
>>>> Wondering why are we returning CqlResult from CassandraConnection, =
ideally it should return ResultSet as jdbc api.
>>>>=20
>>>> Any thoughts?
>>>=20
>>> The execute methods aren't a part of the java.sql.Connection
>>> interface, but they are public, and so shouldn't be returning Thrift
>>> structs.  Maybe we just need to drop the public modifier.
>>>=20
>>> Can you open a ticket Vivek?
>>>=20
>>> --=20
>>> Eric Evans
>>> Acunu | http://www.acunu.com | @acunu