incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vivek Mishra <vivek.mis...@yahoo.com>
Subject Re: CqlResult in CassandraConnection
Date Sun, 28 Aug 2011 17:33:55 GMT
I was looking at AbstractCassandraConnection,AbstractResultSet and AbstractStatement classes.
Name looks to me quite confusing as none of them is an abstract class.  1 more thin, any
specific reason for creating class level hierarchy? 


Plans for any other implementation/s of CassandraConnection, ResultSet and Statement sub class?

Vovel



________________________________
From: Rick Shaw <wfshaw@gmail.com>
To: dev@cassandra.apache.org
Cc: Vivek Mishra <vivek.mishra@yahoo.com>
Sent: Sunday, August 28, 2011 9:39 PM
Subject: Re: CqlResult in CassandraConnection

The class itself is not public, so it is generally protected from misuse, but it is a good
recommendation to remove the public modifier on those non-interface imethods as well. I'll
see to it.

On Aug 28, 2011, at 11:35 AM, Eric Evans wrote:

> On Sun, Aug 28, 2011 at 3:47 AM, Vivek Mishra <vivek.mishra@yahoo.com> wrote:
>> Recently i can see changes made in jdbc connection API.
>> 
>> Wondering why are we returning CqlResult from CassandraConnection, ideally it should
return ResultSet as jdbc api.
>> 
>> Any thoughts?
> 
> The execute methods aren't a part of the java.sql.Connection
> interface, but they are public, and so shouldn't be returning Thrift
> structs.  Maybe we just need to drop the public modifier.
> 
> Can you open a ticket Vivek?
> 
> -- 
> Eric Evans
> Acunu | http://www.acunu.com | @acunu
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message