Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Received-SPF: pass (athena.apache.org: domain of jakers@gmail.com designates
 209.85.210.172 as permitted sender)
Subject: Re: thrift generated java changes
References: 
 <CANEBM30dwdxk-DxJsS_NkPVwFbeS48XRd4D74Fw9jutPBrSvvQ@mail.gmail.com>
From: Jake Luciani <jakers@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: 
 <CANEBM30dwdxk-DxJsS_NkPVwFbeS48XRd4D74Fw9jutPBrSvvQ@mail.gmail.com>
Message-Id: <B4AA7CB7-FA7D-4050-A7DB-8263BA90D794@gmail.com>
Date: Sat, 2 Jul 2011 12:26:08 -0400
To: "dev@cassandra.apache.org" <dev@cassandra.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (iPhone Mail 8J2)

0.8 uses thrift 0.6

=20

On Jul 2, 2011, at 11:40 AM, Joseph Stein <cryptcom@gmail.com> wrote:

> So I am working on https://issues.apache.org/jira/browse/CASSANDRA-2833
>=20
> And when I generate the cassandra.thrift file I am getting weird results a=
nd
> differences
>=20
> Should I be modifying the CounterColumn.java by hand?
>=20
> I am using thrift 0.5.0 and doing
>=20
> thrift -gen java cassandra.thrift from the command line
>=20
> some of the issues (as an example)
>=20
> -    tmpMap.put(_Fields.VALUE, new
> org.apache.thrift.meta_data.FieldMetaData("value",
> org.apache.thrift.TFieldRequirementType.REQUIRED,
> -        new
> org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.=
TType.I64)));
> +    Map<_Fields, FieldMetaData> tmpMap =3D new EnumMap<_Fields,
> FieldMetaData>(_Fields.class);
> +    tmpMap.put(_Fields.NAME, new FieldMetaData("name",
> TFieldRequirementType.REQUIRED,
>=20
>   public CounterColumn setName(byte[] name) {
> -    setName(name =3D=3D null ? (ByteBuffer)null : ByteBuffer.wrap(name));=

> +    setName(ByteBuffer.wrap(name));
>     return this;
>   }
>=20
> -  /** Returns true if field name is set (has been assigned a value) and
> false otherwise */
> +  /** Returns true if field name is set (has been asigned a value) and
> false otherwise */
>=20
> this last ones makes me suspect I am using the wrong thrift version and
> maybe not the right commands?
> http://wiki.apache.org/cassandra/InstallThriftleads me to what I did
> but if there is something different or wrong with
> what I am doing please let me know and I can update the wiki and get back o=
n
> track.
>=20
> and all I did to the cassandra.thrift was:
>=20
> -    2: required i64 value
> +   2: optional i64 value,
> +   3: optional double operand
>=20
>=20
> Thanks!
>=20
> /*
> Joe Stein
> http://www.linkedin.com/in/charmalloc
> Twitter: @allthingshadoop <http://www.twitter.com/allthingshadoop>
> */