Return-Path: Delivered-To: apmail-cassandra-dev-archive@www.apache.org Received: (qmail 68942 invoked from network); 28 Sep 2010 03:53:22 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Sep 2010 03:53:22 -0000 Received: (qmail 72479 invoked by uid 500); 28 Sep 2010 03:53:22 -0000 Delivered-To: apmail-cassandra-dev-archive@cassandra.apache.org Received: (qmail 72397 invoked by uid 500); 28 Sep 2010 03:53:20 -0000 Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list dev@cassandra.apache.org Received: (qmail 72389 invoked by uid 99); 28 Sep 2010 03:53:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Sep 2010 03:53:19 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jbellis@gmail.com designates 209.85.216.179 as permitted sender) Received: from [209.85.216.179] (HELO mail-qy0-f179.google.com) (209.85.216.179) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Sep 2010 03:53:14 +0000 Received: by qyk2 with SMTP id 2so7032870qyk.10 for ; Mon, 27 Sep 2010 20:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=Svou84O3xmZbjIIy8itMMpOt0FFE2TrsX8rz8Jmf7n8=; b=gxBWrFEoKknw2r3Hl0vGtXoNO6QgLxrme43Hsgrnpw14V3pB2UP0ie8/mUl5aY1/mN 7dwDkiof7py24f82SaMsqufrO5LY3OwJTaBcIIZQWZqCmdWTFrA5h4canhLCk7hc4ujV BY1plvNxvXd5GteF/U89sxakJfsBJHpABtOt0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=j3s6yV+gI/NPmnbb0lRzBC+wyMJ+/3VdxsGqSrSrbNDAYbpgquDfFXSN9TktMGm58G 3fv63ZBVxbY0+ifngLetOcVKxwc9zr4CySFDjiDkF3Z0PmB/p+777CPr2njtsqA9gVE8 ZTbYUqKVPh1a79pKps8WMx/GmW+jWUTZrAPOM= MIME-Version: 1.0 Received: by 10.224.54.13 with SMTP id o13mr6313733qag.305.1285645974170; Mon, 27 Sep 2010 20:52:54 -0700 (PDT) Received: by 10.220.186.132 with HTTP; Mon, 27 Sep 2010 20:52:54 -0700 (PDT) In-Reply-To: References: Date: Mon, 27 Sep 2010 20:52:54 -0700 Message-ID: Subject: Re: Atomically adding a column to columns_ From: Jonathan Ellis To: dev Content-Type: text/plain; charset=ISO-8859-1 On Mon, Sep 27, 2010 at 1:54 PM, Peter Schuller wrote: > In the case of this bit of code, I believe, and I am not speaking > authoritatively, the removal only happens in (1) the read path when > filtering results (on presumably query-local data) and (2) during > compaction (on presumably compaction-local data). Right, remove should only be called on local copies rather than the global memtable. It would be good to document this, or, since the correct-even-for-remove logic is not much more complicated, switch to that. -- Jonathan Ellis Project Chair, Apache Cassandra co-founder of Riptano, the source for professional Cassandra support http://riptano.com