incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amol Deshpande" <amol.deshpa...@gazillion.com>
Subject RE: CassandraDaemon setup() method
Date Mon, 13 Sep 2010 20:54:49 GMT
https://issues.apache.org/jira/browse/CASSANDRA-1500

I've submitted the patch above. Please let me know if I've made  a mistake in the patch submission
process. I tried to follow the instructions in the wiki.

Thanks,
-amol

-----Original Message-----
From: Jonathan Ellis [mailto:jbellis@gmail.com] 
Sent: Friday, September 10, 2010 12:17 PM
To: dev@cassandra.apache.org
Subject: Re: CassandraDaemon setup() method

Sounds fine to me.

On Fri, Sep 10, 2010 at 10:34 AM, Amol Deshpande
<amol.deshpande@gazillion.com> wrote:
> Hi,
> I noticed a lot of common code in the thrift and avro
> CassandraDaemon.setup methods. Would it be possible to move those into a
> commonSetup() method in the AbstractCassandraDaemon class ? This will be
> helpful when I add a protocol buffer client-facing interface.
>
> I just tried that and in a quick test the server seemed to start up just
> fine both in thrift and in avro mode.
>
> Should I file a bug, send a patch, or both ?  (or neither :)
>
> Thanks,
> -amol
>



-- 
Jonathan Ellis
Project Chair, Apache Cassandra
co-founder of Riptano, the source for professional Cassandra support
http://riptano.com

Mime
View raw message