Return-Path: Delivered-To: apmail-cassandra-dev-archive@www.apache.org Received: (qmail 75701 invoked from network); 15 Jun 2010 07:45:24 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Jun 2010 07:45:24 -0000 Received: (qmail 66583 invoked by uid 500); 15 Jun 2010 07:45:24 -0000 Delivered-To: apmail-cassandra-dev-archive@cassandra.apache.org Received: (qmail 66246 invoked by uid 500); 15 Jun 2010 07:45:21 -0000 Mailing-List: contact dev-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list dev@cassandra.apache.org Received: (qmail 66238 invoked by uid 99); 15 Jun 2010 07:45:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 07:45:20 +0000 X-ASF-Spam-Status: No, hits=1.0 required=10.0 tests=SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (nike.apache.org: transitioning domain of sylvain@yakaz.com does not designate 209.85.161.44 as permitted sender) Received: from [209.85.161.44] (HELO mail-fx0-f44.google.com) (209.85.161.44) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 07:45:13 +0000 Received: by fxm13 with SMTP id 13so3136990fxm.31 for ; Tue, 15 Jun 2010 00:44:53 -0700 (PDT) Received: by 10.223.29.28 with SMTP id o28mr6617543fac.20.1276587893107; Tue, 15 Jun 2010 00:44:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.118.147 with HTTP; Tue, 15 Jun 2010 00:44:33 -0700 (PDT) In-Reply-To: References: <4C16FBD5.4020306@fourkitchens.com> From: Sylvain Lebresne Date: Tue, 15 Jun 2010 09:44:33 +0200 Message-ID: Subject: Re: Generated code? To: dev@cassandra.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Jun 15, 2010 at 6:43 AM, Masood Mortazavi wrote: > On Mon, Jun 14, 2010 at 9:04 PM, David Strauss wr= ote: > >> On 2010-06-15 03:58, Masood Mortazavi wrote: >> > Hi, >> > >> > My assumption is that what one finds in >> > >> > =A0 =A0 =A0 interface/thrift/gen-java >> > >> > is actually generated code. >> > >> > If so, why is it checked in as source under SVN? >> > >> > (Certainly, the avro generated code doesn't seem to be checked in.) >> > >> > Regards, >> > Masood >> > >> >> It simplifies the end user's build process. If the code isn't in >> Subversion, then you'd need to get all the Thrift dependencies and do >> the generation yourself just to build Cassandra. Sure, there are other >> methods that don't involve checking into Subversion, but they're more >> complex. >> > > > Thank you very much for explaining this. It helps me understand the > reasoning. > > Out of curiosity, I'm wondering whether those dependencies are any more t= han > one or more jar files in the lib. The lib is already loaded with many oth= er > jar files . . . The thrift compiler is no java program. It is a written in C++ and have qui= te a few dependencies (boost for instance if memory serves) that don't make distribution that easy. > (I'm not a thrift expert but did work on RMI in the JDK, some years go, s= o I > can guess what may be needed to generate the code. Avro, in Cassandra, se= ems > to have been able to get away with some jar inclusion in lib. Having one > system for Avro and quite another for Thrift seems a bit odd but maybe I'= m > missing something larger.) > > - m. >