incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Todd Blose <thewagesoff...@gmail.com>
Subject Re: whitespace patch
Date Sun, 27 Jun 2010 00:57:31 GMT
You should create a ticket in JIRA, and attach the patch to it. The process
is described here: http://wiki.apache.org/cassandra/HowToContribute

On Sat, Jun 26, 2010 at 5:47 PM, Marty Greenia <martygreenia@gmail.com>wrote:

> Hello all,
>
> In browsing through the code, I spent some time fixing up the whitespace --
> mostly replacing tabs and putting '{' on new lines. The number of files it
> touches is large, but it is all just spaces and newlines.
>
> I've attached a patch. What patch submission protocol have you been using?
> I didn't see any specific protocol mentioned on the wiki, so I figured
> emailing the list was the best for now.
>
>
> Also, I noticed one thing that the style guide allows that might be worth
> restricting: One-line 'if' statements without brackets -- especially when
> the body also includes a comment. I saw a few of these occur throughout the
> code; I think they are awkward to read, and prone to error. Any thoughts
> about requiring brackets around all if statement bodies in the style guid?
>
> Thanks!
> Marty
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message